Skip to content

Fix crash during viewport/scissor updates when validation layers are enabled.#88

Merged
crud89 merged 3 commits intomainfrom
fix-dynamic-state-vl-crash
Mar 26, 2023
Merged

Fix crash during viewport/scissor updates when validation layers are enabled.#88
crud89 merged 3 commits intomainfrom
fix-dynamic-state-vl-crash

Conversation

@crud89
Copy link
Copy Markdown
Owner

@crud89 crud89 commented Mar 26, 2023

Describe the pull request

This PR fixes an issue introduced in #86, where setting the viewport and/or scissor state with validation layers enabled could crash the application. This was due to a missing explicit version in the app creation info. Setting this to require API version 1.3, fixes the issue.

@crud89 crud89 added Priority: High A high priority issue. Bug 🐞 Something isn't working. Type: Requirement Vulkan πŸŒ‹ The issue involves the Vulkan backend. labels Mar 26, 2023
@crud89 crud89 added this to the Alpha #04 milestone Mar 26, 2023
@crud89 crud89 self-assigned this Mar 26, 2023
@crud89 crud89 marked this pull request as ready for review March 26, 2023 07:28
@crud89 crud89 merged commit a68ea34 into main Mar 26, 2023
@crud89 crud89 deleted the fix-dynamic-state-vl-crash branch March 26, 2023 09:18
@crud89 crud89 mentioned this pull request Mar 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug 🐞 Something isn't working. Priority: High A high priority issue. Vulkan πŸŒ‹ The issue involves the Vulkan backend.

Projects

Status: v0.4.1

Development

Successfully merging this pull request may close these issues.

1 participant