Conversation
β¦ render pipeline interface.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
This PR moves the viewport, scissor, blend factors and stencil reference states out of the render pipeline state. This allows for them to be altered without requiring a second pipeline instance. Instead, the command buffer now provides an interface to set the state accordingly.
For the Vulkan backend, this uses the
VK_EXT_extended_dynamic_stateextension, which has been promoted to core with Vulkan 1.3. This is a good excuse to raise the minimum required SDK version to 1.3.204.1.Note, that it is now mandatory to set (at least) the viewport and scissor after binding a pipeline and not later than issuing a draw call, e.g.:
All samples and the tutorial have been updated to reflect those changes.
Known issues
Note that calling(See #88)setViewportsorsetScissorswith validation layers enabled will crash the application. This is due to a bug in the validation layer implementation, which hopefully will be resolved soon.