Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
This PR adds support for user-defined debug markers. Command queues now expose three additional methods for this purpose:
All three methods are optional and are only ever built for debug builds in the default backends. Additionally, the methods are only implemented for x64 builds in the DirectX 12 backend. If the methods are not available, they will no-op.
Under the hood, this PR introduces some additional changes to debugging. First of all, the DirectX 12 backend now uses the official WinPixEventRuntime, which is integrated as an overlay-port and loaded from NuGet. For this reason, vcpkg has been updated to version 2022.10.19. For the Vulkan backend, the extension
VK_EXT_debug_utilsis now enabled by default in debug builds.