Decouple descriptor counts in descriptor layouts from unbounded array sizes.#166
Merged
Decouple descriptor counts in descriptor layouts from unbounded array sizes.#166
Conversation
crud89
added
Vulkan 🌋
Owner
Author
|
Run: checks |
Owner
Author
|
Tests currently fail, because this PR removes the static constant that initializes the descriptor count for the unbounded array in the ray-tracing test. This is problem will be addressed with a future PR targeting #167. I'll merge this anyway in the meantime. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
This PR removes the implicit relationship between descriptor counts in a descriptor layout and their treatment as unbounded runtime arrays. This allows for more granular setting of descriptor counts for unbounded arrays, which is important in the Vulkan backend, where multiple unbounded descriptor arrays can now be configured in a way that they do no longer exceed device limits. This is, however, currently only possible by defining the descriptor set from code. Support for shader reflection will be part of a future PR.
Related issues