Validate and offset descriptor indices when binding image and sampler arrays.#159
Merged
Validate and offset descriptor indices when binding image and sampler arrays.#159
Conversation
…es before binding.
crud89
added
Bug 🐞
Owner
Author
|
Run: checks |
crud89
added a commit
that referenced
this pull request
Sep 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
This resolves an issue where sampler and image arrays are not properly bound. This happend because the index to the first descriptor was not correctly offset. This PR validates if the target descriptor is valid for a descriptor array at a specific binding and properly computes the descriptor offset before copying the desriptor to the global heap(s).
Unfortunately no test for this issue is implemented, as this does neither trigger the validation layer, nor any state changes in the engine itself.
Related issues
Fixes #154