Skip to content

Several descriptor set related improvements.#147

Merged
crud89 merged 6 commits intomainfrom
descriptor-set-overhaul
Mar 13, 2025
Merged

Several descriptor set related improvements.#147
crud89 merged 6 commits intomainfrom
descriptor-set-overhaul

Conversation

@crud89
Copy link
Copy Markdown
Owner

@crud89 crud89 commented Mar 13, 2025

Describe the pull request

This PR addresses several minor issues related to descriptor sets:

  • The root parameter index is no longer stored on the descriptor set or push constants range layout. Instead the pipeline stores a root parameter index for each space. This makes it easier to re-use descriptor sets over multiple pipelines, as long as they remain compatible (which the application has to ensure).
  • Push constants can now be used with compute shaders.
  • In Vulkan, the reference to the parent pipeline layout for push constant ranges has been removed.

@crud89 crud89 added Vulkan πŸŒ‹ The issue involves the Vulkan backend. DX12 ❎ The issue involves the DX12 backend. labels Mar 13, 2025
@crud89 crud89 added this to the Alpha #04 milestone Mar 13, 2025
@crud89 crud89 self-assigned this Mar 13, 2025
@crud89 crud89 added this to LiteFX Mar 13, 2025
@crud89 crud89 changed the title Descriptor set overhaul Several descriptor set related improvements. Mar 13, 2025
@crud89 crud89 moved this to In Progress in LiteFX Mar 13, 2025
@crud89
Copy link
Copy Markdown
Owner Author

crud89 commented Mar 13, 2025

Run: checks

@crud89 crud89 merged commit c15e57e into main Mar 13, 2025
9 checks passed
@crud89 crud89 deleted the descriptor-set-overhaul branch March 13, 2025 19:54
@crud89 crud89 moved this from In Progress to v0.4.1 in LiteFX Mar 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DX12 ❎ The issue involves the DX12 backend. Vulkan πŸŒ‹ The issue involves the Vulkan backend.

Projects

Status: v0.4.1

Development

Successfully merging this pull request may close these issues.

1 participant