Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
This PR allows to statically link the engine libraries, which increases executable file size, but reduces overall file size as well as some performance overhead. Keep in mind that some dependencies cannot be statically linked (e.g., the d3d12 libraries and the Vulkan loader). Also this does not statically link the CRT.
Alongside some changes to the overall build system have been made. The overlay port configuration has been removed from the CMake script into a vcpkg configuration file. Also overlay triplets have been introduced, that are used for proper library linkage setup and allow to restrict builds to only build release versions of dependencies, which should speed up CI builds.
Related issues
This partially addresses issue #101.