Allow unbound descriptors in descriptor sets.#126
Merged
Conversation
crud89
added
Vulkan 🌋
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Currently trying to update a descriptor in a descriptor set, that does not exist in the pipeline layout throws an exception. However, when authoring shaders, it is common that descriptors are not actually used and get removed from the shader. Shader reflection in this case does produce a pipeline layout without the descriptor, which then would cause an exception to be thrown. To simplify this process, this no longer throws with this PR, but rather issues a warning. This removes the need for changing the application itself frequently during shader development.