Skip to content

Command buffer improvements#123

Merged
crud89 merged 4 commits intomainfrom
command-buffer-qol
Feb 9, 2024
Merged

Command buffer improvements#123
crud89 merged 4 commits intomainfrom
command-buffer-qol

Conversation

@crud89
Copy link
Copy Markdown
Owner

@crud89 crud89 commented Feb 9, 2024

Describe the pull request

This PR improves command buffers to allow for some boilerplate code to be removed from application implementations:

  • Staging buffers can now be avoided by directly mapping memory through an extended ICommandBuffer::transfer overload.
  • It is now possible to bind multiple descriptor sets at once using a new ICommandBuffer::bind overload. This can even be advantageous for Vulkan descriptor sets, if they are in a contiguous range, as this allows the engine to bind them through a single command (although the effect is probably minimal).
  • Barriers can now be created from command buffers.

@crud89 crud89 marked this pull request as ready for review February 9, 2024 17:44
@crud89 crud89 self-assigned this Feb 9, 2024
@crud89 crud89 added Vulkan πŸŒ‹ The issue involves the Vulkan backend. DX12 ❎ The issue involves the DX12 backend. labels Feb 9, 2024
@crud89 crud89 added this to the Alpha #04 milestone Feb 9, 2024
@crud89 crud89 changed the title Command buffer qol Command buffer improvements Feb 9, 2024
@crud89 crud89 merged commit f64f108 into main Feb 9, 2024
@crud89 crud89 deleted the command-buffer-qol branch February 9, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DX12 ❎ The issue involves the DX12 backend. Vulkan πŸŒ‹ The issue involves the Vulkan backend.

Projects

Status: v0.4.1

Development

Successfully merging this pull request may close these issues.

1 participant