Skip to content

Implement indirect draw and dispatch.#118

Merged
crud89 merged 53 commits intomainfrom
execute-indirect
Jun 9, 2024
Merged

Implement indirect draw and dispatch.#118
crud89 merged 53 commits intomainfrom
execute-indirect

Conversation

@crud89
Copy link
Copy Markdown
Owner

@crud89 crud89 commented Jan 11, 2024

Describe the pull request

This PR adds support for indirect draw (both indexed and non-indexed) and dispatch. Buffers can be marked with BufferUsage::Indirect to indicate that they store indirect draw commands. New structures (IndirectBatch, IndirectIndexedBatch and IndirectDispatch) have been added, which are not required but recommended to be used to record indirect commands into indirect draw/dispatch buffers, as the command layout is defined by convention.

The Indirect sample shows how to use a compute shader to perform GPU culling to write an indirect buffer, which is then executed on the graphics pipeline to draw simple geometries.

Additionally, some improvements have been made to simplify recording of indirect draw buffers:

  • Buffers now support counter variables (which allows to use AppendStructuredBuffer and similar descriptor types).
  • In Vulkan, unbounded descriptor arrays are no longer required to have pre-defined maximum sizes.
  • Shader reflection has been improved to better differ between structured and byte address buffers (though they are semantically the same in Vulkan most of the times anyway).

Related issues

@crud89 crud89 added Type: Requirement Vulkan 🌋 The issue involves the Vulkan backend. DX12 ❎ The issue involves the DX12 backend. labels Jan 11, 2024
@crud89 crud89 added this to the Alpha #04 milestone Jan 11, 2024
@crud89 crud89 self-assigned this Jan 11, 2024
@crud89 crud89 linked an issue Jan 11, 2024 that may be closed by this pull request
@crud89
Copy link
Copy Markdown
Owner Author

crud89 commented May 5, 2024

I've merged all upstream changes and did some final tests, however I keep this blocked until a new Vulkan SDK ships with a recent DXC binary supporting Shader Model 6.8.

@crud89 crud89 modified the milestones: Alpha #05, Alpha #04 May 5, 2024
@crud89 crud89 marked this pull request as ready for review June 9, 2024 09:36
@crud89 crud89 marked this pull request as draft June 9, 2024 09:40
@crud89 crud89 marked this pull request as ready for review June 9, 2024 10:05
@crud89 crud89 merged commit 818ec4f into main Jun 9, 2024
@crud89 crud89 deleted the execute-indirect branch June 9, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

DX12 ❎ The issue involves the DX12 backend. Vulkan 🌋 The issue involves the Vulkan backend.

Projects

Status: v0.4.1

Development

Successfully merging this pull request may close these issues.

Support GPU-based rendering (draw indirect).

1 participant