Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the pull request
This PR simplifies binding descriptor sets. Previously the pipeline that consumes the descriptor sets had to be explicitly provided every time a descriptor set was bound. With the new overload to
ICommandBuffer::bind, the pipeline that has been passed to the last call toICommandBuffer::usewill be stored and used for binding. If no pipeline has been used before calling this overload, an error is raised. Those changes make it easier decouple resource binding from pipeline management and keeps the interface more in line with the otherbindoverloads that handle index and vertex buffers: