Skip to content

Make index buffer layout optional.#109

Merged
crud89 merged 2 commits intomainfrom
optional_index_layout
Dec 20, 2023
Merged

Make index buffer layout optional.#109
crud89 merged 2 commits intomainfrom
optional_index_layout

Conversation

@crud89
Copy link
Copy Markdown
Owner

@crud89 crud89 commented Dec 20, 2023

Describe the pull request

Providing an index buffer layout is now optional when defining an input assembler state. Both vertex buffer and index buffer layouts return pointers instead of references. This also allows to make the index buffer propery on the input assembler noexcept.

Related issues

@crud89 crud89 added Priority: Medium A issue with normal priority. Bug 🐞 Something isn't working. Vulkan πŸŒ‹ The issue involves the Vulkan backend. DX12 ❎ The issue involves the DX12 backend. labels Dec 20, 2023
@crud89 crud89 added this to the Alpha #04 milestone Dec 20, 2023
@crud89 crud89 self-assigned this Dec 20, 2023
@crud89 crud89 marked this pull request as ready for review December 20, 2023 11:33
@crud89 crud89 merged commit a1190bc into main Dec 20, 2023
@crud89 crud89 deleted the optional_index_layout branch December 20, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug 🐞 Something isn't working. DX12 ❎ The issue involves the DX12 backend. Priority: Medium A issue with normal priority. Vulkan πŸŒ‹ The issue involves the Vulkan backend.

Projects

Status: v0.4.1

Development

Successfully merging this pull request may close these issues.

Index buffers should be optional.

1 participant