Improve core guideline conformance. by crud89 · Pull Request #103 · crud89/LiteFX

crud89 · 2023-11-04T09:47:27Z

Describe the pull request

This PR improves conformance with the C++ core guidelines in two aspects:

It removes redundant combined occurrences of virtual and override (C.128) and declares backend classes final.
Enumerations and integrated types that can be trivially passed on the stack are now no longer passed by-reference (F.15).

crud89 added 8 commits November 3, 2023 20:57

Replace references with integrated types in core projects.

248029c

Allow conversions at compile-time.

43f180c

Pass enumerations by value.

03b6bfc

Pass integrated types by value.

e6e43ff

Also pass topology by value.

d560c93

Avoid redundant combinations of virtual and override.

f83e8e0

Declare backend classes final.

44d12d6

Mention improvements to core guideline conformance.

f9d9b21

crud89 added Priority: Medium A issue with normal priority. Type: Requirement Build 🛠 Issues that involve the build process. labels Nov 4, 2023

crud89 added this to the Alpha #04 milestone Nov 4, 2023

crud89 self-assigned this Nov 4, 2023

Merge branch 'main' into remove-unnecessary-indirections

dc0b252

crud89 merged commit 6bea79b into main Nov 4, 2023

crud89 deleted the remove-unnecessary-indirections branch November 4, 2023 10:16

Provide feedback