I've looked into the issue, but it appears unrelated. It is fixed when removing the covariance from the return value of the operator[] and image functions of the FrameBuffer implementations (only the ones that take a StringView are affected):

//inline const IVulkanImage& operator[](StringView renderTargetName) const override {
inline const IImage& operator[](StringView renderTargetName) const override {
    return this->resolveImage(hash(renderTargetName));
}

//inline const IVulkanImage& image(StringView renderTargetName) const override {
inline const IImage& image(StringView renderTargetName) const override {
    return this->resolveImage(hash(renderTargetName));
}

This indeed appears like a regression with the compiler. I will see if I can create a MRE from it and report it. ~~As for the engine, I will try to move this to the base class and see if it resolves the issue.~~ (it doesn't)

Update: This was indeed a separate issue, introduced by Visual Studio 17.11 and fixed in 17.12 or 17.11.5.

Nevertheless, ray queries are still broken. I've managed to create two identical PIX captures, one from the release and the other one from the debug builds. Both use the same shaders (debug version, as they retain the PDBs). I've spent quite some time investigating differences, but couldn't find any. I've tested the samples on a 2080 Ti, where RT works, but RQs always return COMMITTED_NOTHING. On my 4080, however, both ray tracing samples show invalid geometry. I suspect this is somehow related to how acceleration structures are built in the D3D backend.

Interestingly RelWithDebInfo also works, so just MSVC release is broken. Also I've tested RT validation with nvapi, but nothing gets reported there either. I suspect we're hitting some UB here... My guess would be some lambda capture, as I ran into this before. On the other hand, PIX captures are unremarkable in this regard.

Release builds break D3D12 ray tracing samples. #136

Description

Metadata

Metadata

Assignees

Labels

Projects

Milestone

Relationships

Development

Issue actions