fix: support non-RSA GPG signing keys#313
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes commit-signing setup in entrypoint.sh so the action can work with non-RSA GPG secret keys (e.g., ed25519 and nistp384) by deriving the signing key ID from GnuPG’s machine-readable output, addressing issue #295.
Changes:
- Switch GPG key ID extraction from an RSA-specific regex to parsing
gpg --with-colons --list-secret-keys. - Keep the “first primary secret key” selection behavior by taking the first
secrecord.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #295
Verification
sh -n entrypoint.shgit diff --checkmaster)setup_commit_signing()with an imported ed25519 key and verified the resulting signed commit