lib/Epub/Epub/parsers/ChapterHtmlSlimParser.cpp (1)

55-57: Consider marking as static for internal linkage.

This helper is only used within this translation unit. Adding static would clarify intent and potentially allow better compiler optimization.

Suggested change

-bool isTableStructuralTag(const char* name) {
+static bool isTableStructuralTag(const char* name) {
   return strcmp(name, "table") == 0 || strcmp(name, "tr") == 0 || strcmp(name, "td") == 0 || strcmp(name, "th") == 0;
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@lib/Epub/Epub/parsers/ChapterHtmlSlimParser.cpp` around lines 55 - 57, The
helper function isTableStructuralTag has internal-only usage and should be given
internal linkage: mark it static (or anonymous-namespace if preferred) so the
compiler knows it's translation-unit local; update the function
declaration/definition for isTableStructuralTag to use static and rebuild to
ensure no external linkage remains.

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

lib/Epub/Epub/parsers/ChapterHtmlSlimParser.cpp (2)

184-187: Consider extracting alignment resolution to a helper.

This alignment resolution logic (defaulting CssTextAlign::None to Justify) is duplicated from parseAndBuildPages (lines 689-692). Extracting it to a small helper method would reduce duplication.

Example helper

// In class declaration or as private inline helper
CssTextAlign resolveAlignment() const {
  return (paragraphAlignment == static_cast<uint8_t>(CssTextAlign::None))
             ? CssTextAlign::Justify
             : static_cast<CssTextAlign>(paragraphAlignment);
}

Then use resolveAlignment() in both locations.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@lib/Epub/Epub/parsers/ChapterHtmlSlimParser.cpp` around lines 184 - 187,
Extract the duplicated alignment-resolution logic into a small helper (e.g.,
CssTextAlign resolveAlignment() const) on the ChapterHtmlSlimParser class and
replace both occurrences: the current inline ternary using
self->paragraphAlignment (which sets tableCellBlockStyle.alignment) and the
identical logic in parseAndBuildPages (lines ~689-692). The helper should return
CssTextAlign::Justify when paragraphAlignment equals
static_cast<uint8_t>(CssTextAlign::None) and otherwise return
static_cast<CssTextAlign>(paragraphAlignment); then call resolveAlignment() in
place of the duplicated expressions.

---

641-654: Minor: Conditions can be consolidated.

Lines 641-647 both set nextWordContinues = false for different table structural tags. Consider combining for clarity:

Consolidated condition

-  if (self->tableDepth == 1 && (strcmp(name, "td") == 0 || strcmp(name, "th") == 0)) {
-    self->nextWordContinues = false;
-  }
-
-  if (self->tableDepth == 1 && (strcmp(name, "tr") == 0)) {
-    self->nextWordContinues = false;
-  }
-
-  if (self->tableDepth == 1 && strcmp(name, "table") == 0) {
+  if (self->tableDepth == 1 && isTableStructuralTag(name)) {
+    self->nextWordContinues = false;
+  }
+
+  if (self->tableDepth == 1 && strcmp(name, "table") == 0) {
     self->tableDepth -= 1;
     self->tableRowIndex = 0;
     self->tableColIndex = 0;
-    self->nextWordContinues = false;
   }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@lib/Epub/Epub/parsers/ChapterHtmlSlimParser.cpp` around lines 641 - 654,
Consolidate repeated conditional branches that set self->nextWordContinues =
false when at tableDepth == 1 by merging checks for "td", "th", and "tr" into a
single if that checks tableDepth == 1 and whether name is "td" || "th" || "tr",
and keep the existing separate block for "table" which additionally decrements
self->tableDepth and resets self->tableRowIndex and self->tableColIndex; update
the code around the occurrences of self->tableDepth, self->tableRowIndex,
self->tableColIndex and nextWordContinues in ChapterHtmlSlimParser.cpp to remove
duplication and preserve current behavior.

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro