feat: Scale cover images up if they're smaller than the device resolution#964
Merged
daveallie merged 1 commit intocrosspoint-reader:masterfrom Feb 19, 2026
Merged
Conversation
Contributor
📝 WalkthroughWalkthroughBoth JPEG and PNG BMP converter implementations are updated to enable scaling when target dimensions differ from source dimensions (not just when exceeding them), with enhanced row processing logic to emit multiple output rows per source row during upscaling and refined accumulator reset behavior. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
sam-lord
changed the title
znelson
approved these changes
Feb 18, 2026
daveallie
approved these changes
Feb 19, 2026
Member
daveallie
left a comment
daveallie
left a comment
There was a problem hiding this comment.
Confirmed it's working well for a book I have with a small cover
This was referenced Feb 19, 2026
saslv
pushed a commit
to saslv/crosspoint-reader
that referenced
this pull request
Feb 19, 2026
…tion (crosspoint-reader#964) ## Summary **What is the goal of this PR?** * Implement feature request [crosspoint-reader#954](crosspoint-reader#954) * Ensure cover images are scaled up to match the dimensions of the screen, as well as scaled down **What changes are included?** * Naïve implementation for scaling up the source image ## Additional Context If you find the extra comments to be excessive I can pare them back. Edit: Fixed title --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**< YES >**_
el
pushed a commit
to el/crosspoint-reader
that referenced
this pull request
Feb 19, 2026
…tion (crosspoint-reader#964) ## Summary **What is the goal of this PR?** * Implement feature request [crosspoint-reader#954](crosspoint-reader#954) * Ensure cover images are scaled up to match the dimensions of the screen, as well as scaled down **What changes are included?** * Naïve implementation for scaling up the source image ## Additional Context If you find the extra comments to be excessive I can pare them back. Edit: Fixed title --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**< YES >**_
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 20, 2026
…tion (crosspoint-reader#964) ## Summary **What is the goal of this PR?** * Implement feature request [crosspoint-reader#954](crosspoint-reader#954) * Ensure cover images are scaled up to match the dimensions of the screen, as well as scaled down **What changes are included?** * Naïve implementation for scaling up the source image ## Additional Context If you find the extra comments to be excessive I can pare them back. Edit: Fixed title --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**< YES >**_
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What is the goal of this PR?
What changes are included?
Additional Context
If you find the extra comments to be excessive I can pare them back.
Edit: Fixed title
AI Usage
While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.
Did you use AI tools to help write this code? < YES >