feat: PoC of fonts on data partition#960
Closed
znelson wants to merge 2 commits intocrosspoint-reader:masterfrom
Closed
feat: PoC of fonts on data partition#960znelson wants to merge 2 commits intocrosspoint-reader:masterfrom
znelson wants to merge 2 commits intocrosspoint-reader:masterfrom
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
6 tasks
ngxson
reviewed
Feb 18, 2026
|
|
||
| const auto& uiGroup = groupDir[uiGroupIndex]; | ||
| const void* ptr = nullptr; | ||
| err = esp_partition_mmap(partition, uiGroup.dataOffset, uiGroup.dataSize, SPI_FLASH_MMAP_DATA, &ptr, &uiMmapHandle); |
Contributor
There was a problem hiding this comment.
Note that when working on #596 , I ran into the problem that we may not have enough data pages for mapping, so we may need to fallback to using instruction pages and having to access data with 4-byte alignment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What is the goal of this PR?
8 MB executable, 8 MB data/fonts. The UI fonts and selected reader font are mmap-ed at runtime.
Includes the Latin-B characters proposed in #940 to demonstrate expanded font capabilities.
Additional Context
Flash with:
Firmware size w/o fonts:
AI Usage
While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.
Did you use AI tools to help write this code? YES Claude Opus 4.6