fix: Added missing up/down button labels by znelson · Pull Request #935 · crosspoint-reader/crosspoint-reader

znelson · 2026-02-16T18:10:01Z

Summary

What is the goal of this PR?

In some places, button labels are omitted intentionally because the button has no purpose in the activity. I noticed a few obvious cases, like Home > File Transfer and Settings > System > Language, where the up and down button labels were missing. This change fixes those and all similar instances I could find.

AI Usage

While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.

Did you use AI tools to help write this code? NO

coderabbitai · 2026-02-16T18:10:08Z

📝 Walkthrough

Walkthrough

Multiple activity files are updated to include directional navigation hints in button label rendering. The mapLabels function calls now receive STR_DIR_UP and STR_DIR_DOWN as parameters, replacing previously empty string arguments. These changes enhance UI button hints with up/down navigation indicators across browsing, network, reader, and settings interfaces.

Changes

Cohort / File(s)	Summary
Settings Activities `src/activities/settings/CalibreSettingsActivity.cpp`, `src/activities/settings/KOReaderSettingsActivity.cpp`, `src/activities/settings/LanguageSelectActivity.cpp`	Updated mapLabels calls to include STR_DIR_UP and STR_DIR_DOWN directional hints for button labels instead of empty strings.
Other Activities `src/activities/browser/OpdsBookBrowserActivity.cpp`, `src/activities/network/NetworkModeSelectionActivity.cpp`, `src/activities/reader/KOReaderSyncActivity.cpp`	Updated mapLabels calls to include STR_DIR_UP and STR_DIR_DOWN directional hints for button labels instead of empty strings.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: adding missing up/down button labels across multiple activity files.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into `master`
Description check	✅ Passed	The pull request description clearly relates to the changeset, explaining the goal of adding missing up/down button labels across multiple activity files.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

znelson · 2026-02-16T18:12:06Z

src/activities/reader/KOReaderSyncActivity.cpp

-    // Bottom button hints: show Back and Select
-    const auto labels = mappedInput.mapLabels(tr(STR_BACK), tr(STR_SELECT), "", "");
+    // Bottom button hints
+    const auto labels = mappedInput.mapLabels(tr(STR_BACK), tr(STR_SELECT), tr(STR_DIR_UP), tr(STR_DIR_DOWN));


This is the SHOWING_RESULT case, where up and down are handled on lines 365-373

znelson · 2026-02-16T18:14:27Z

src/activities/browser/OpdsBookBrowserActivity.cpp

    confirmLabel = tr(STR_DOWNLOAD);
  }
-  const auto labels = mappedInput.mapLabels(tr(STR_BACK), confirmLabel, "", "");
+  const auto labels = mappedInput.mapLabels(tr(STR_BACK), confirmLabel, tr(STR_DIR_UP), tr(STR_DIR_DOWN));


Up and down are handled on lines 116-134

znelson · 2026-02-16T18:15:19Z

src/activities/network/NetworkModeSelectionActivity.cpp


  // Draw help text at bottom
-  const auto labels = mappedInput.mapLabels(tr(STR_BACK), tr(STR_SELECT), "", "");
+  const auto labels = mappedInput.mapLabels(tr(STR_BACK), tr(STR_SELECT), tr(STR_DIR_UP), tr(STR_DIR_DOWN));


Up and down are handled on lines 46-54

znelson · 2026-02-16T18:16:10Z

src/activities/settings/CalibreSettingsActivity.cpp


  // Draw button hints
-  const auto labels = mappedInput.mapLabels(tr(STR_BACK), tr(STR_SELECT), "", "");
+  const auto labels = mappedInput.mapLabels(tr(STR_BACK), tr(STR_SELECT), tr(STR_DIR_UP), tr(STR_DIR_DOWN));


Up and down are handled on lines 45-53

znelson · 2026-02-16T18:16:48Z

src/activities/settings/KOReaderSettingsActivity.cpp


  // Draw button hints
-  const auto labels = mappedInput.mapLabels(tr(STR_BACK), tr(STR_SELECT), "", "");
+  const auto labels = mappedInput.mapLabels(tr(STR_BACK), tr(STR_SELECT), tr(STR_DIR_UP), tr(STR_DIR_DOWN));


Up and down are handled on lines 47-55

znelson · 2026-02-16T18:17:18Z

src/activities/settings/LanguageSelectActivity.cpp


  // Button hints
-  const auto labels = mappedInput.mapLabels(tr(STR_BACK), tr(STR_SELECT), "", "");
+  const auto labels = mappedInput.mapLabels(tr(STR_BACK), tr(STR_SELECT), tr(STR_DIR_UP), tr(STR_DIR_DOWN));


Up and down are handled on lines 33-41

CaptainFrito

This is also done in #732 but might as well get it merged sooner

## Summary **What is the goal of this PR?** In some places, button labels are omitted intentionally because the button has no purpose in the activity. I noticed a few obvious cases, like Home > File Transfer and Settings > System > Language, where the up and down button labels were missing. This change fixes those and all similar instances I could find. --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_

…QWId fix: Added missing up/down button labels (crosspoint-reader#935)

fix: Added missing up/down button labels

ea7d5f8

znelson commented Feb 16, 2026

View reviewed changes

znelson marked this pull request as ready for review February 16, 2026 18:17

coderabbitai bot approved these changes Feb 16, 2026

View reviewed changes

ngxson requested a review from CaptainFrito February 18, 2026 10:56

CaptainFrito approved these changes Feb 18, 2026

View reviewed changes

osteotek approved these changes Feb 18, 2026

View reviewed changes

osteotek merged commit d02e21a into crosspoint-reader:master Feb 18, 2026
8 checks passed

daveallie mentioned this pull request Feb 19, 2026

chore(release): 1.1.0 Release Candidate #992

Merged

znelson deleted the up-down-labels branch February 20, 2026 14:29

coderabbitai bot mentioned this pull request Feb 23, 2026

fix: Update activity was missing "Back" button label #1128

Merged

anthonydgallo added a commit to anthonydgallo/crosspoint-reader that referenced this pull request Feb 23, 2026

Merge pull request #35 from anthonydgallo/claude/sync-upstream-fork-6…

6205c63

…QWId fix: Added missing up/down button labels (crosspoint-reader#935)

coderabbitai bot mentioned this pull request Mar 1, 2026

fix: Hide unusable button hints when viewing empty directory #1253

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: Added missing up/down button labels#935

fix: Added missing up/down button labels#935
osteotek merged 1 commit intocrosspoint-reader:masterfrom
znelson:up-down-labels

znelson commented Feb 16, 2026 •

edited

Loading

Uh oh!

coderabbitai bot commented Feb 16, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Uh oh!

znelson Feb 16, 2026

Uh oh!

znelson Feb 16, 2026

Uh oh!

znelson Feb 16, 2026

Uh oh!

znelson Feb 16, 2026

Uh oh!

znelson Feb 16, 2026

Uh oh!

znelson Feb 16, 2026

Uh oh!

CaptainFrito left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

znelson commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

AI Usage

Uh oh!

coderabbitai bot commented Feb 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Uh oh!

znelson Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

znelson Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

znelson Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

znelson Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

znelson Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

znelson Feb 16, 2026

Choose a reason for hiding this comment

Uh oh!

CaptainFrito left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

znelson commented Feb 16, 2026 •

edited

Loading

coderabbitai bot commented Feb 16, 2026 •

edited

Loading