feat: increase keyboard font size for classic theme#897
Conversation
ariel-lindemann
changed the title
|
Commendable effort, but I think @CaptainFrito has this already covered in his PR #732 |
|
Thanks for the heads up, the layout with the keys at the bottom looks very nice. But after having tested it on my device, I've noticed that his inplementation only applies with the Lyra theme. For classic it still has the old layout. So I still think my PR has merit as long as the Classic theme is still supported, which afaik it is |
ariel-lindemann
force-pushed
the
increase_kb_font_size
branch
from
86c2942 to
fe07298
Compare
|
No actionable comments were generated in the recent review. 🎉 📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
🔇 Additional comments (1)
📝 WalkthroughWalkthroughUpdated keyboard key dimensions and spacing in BaseTheme metrics: keyboardKeyWidth increased from 18 to 22, keyboardKeyHeight from 18 to 30, and keyboardKeySpacing from 3 to 10. No control flow or error handling changes. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related issues
🚥 Pre-merge checks | ✅ 1 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
ariel-lindemann
changed the title
|
I've updated this to incorporate the changes fom upstream and provide the larger keyboard to classic theme users as well |
…r#897) ## Summary * **What is the goal of this PR?** (e.g., Implements the new feature for file uploading.) Adresses Feature Request crosspoint-reader#896 * **What changes are included?** Changed key dimensions, initial positions and margins. ## Additional Context The keyboard now looks like this:  --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_
…r#897) ## Summary * **What is the goal of this PR?** (e.g., Implements the new feature for file uploading.) Adresses Feature Request crosspoint-reader#896 * **What changes are included?** Changed key dimensions, initial positions and margins. ## Additional Context The keyboard now looks like this:  --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_
…r#897) ## Summary * **What is the goal of this PR?** (e.g., Implements the new feature for file uploading.) Adresses Feature Request crosspoint-reader#896 * **What changes are included?** Changed key dimensions, initial positions and margins. ## Additional Context The keyboard now looks like this:  --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_
3 participants
Summary
Adresses Feature Request #896
Changed key dimensions, initial positions and margins.
Additional Context
The keyboard now looks like this:
AI Usage
While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.
Did you use AI tools to help write this code? NO