src/activities/util/BmpViewerActivity.cpp (2)

26-33: Large images are clipped rather than scaled.

When the BMP dimensions exceed screen size, the image is drawn at its original size and clipped. This may cut off parts of larger images. If full visibility is desired, consider scaling the image to fit within screen bounds while maintaining aspect ratio.

💡 Optional: Scale large images to fit

       // Calculate centering
-      int32_t xOffset = (renderer.getScreenWidth() - bmpW) / 2;
-      int32_t yOffset = (renderer.getScreenHeight() - bmpH) / 2;
-
-      if (xOffset < 0) xOffset = 0;
-      if (yOffset < 0) yOffset = 0;
-
-      renderer.drawBitmap(bmp, xOffset, yOffset, bmpW, bmpH);
+      int32_t screenW = renderer.getScreenWidth();
+      int32_t screenH = renderer.getScreenHeight();
+      int32_t drawW = bmpW;
+      int32_t drawH = bmpH;
+
+      // Scale down if image exceeds screen dimensions
+      if (bmpW > screenW || bmpH > screenH) {
+        float scaleX = static_cast<float>(screenW) / bmpW;
+        float scaleY = static_cast<float>(screenH) / bmpH;
+        float scale = std::min(scaleX, scaleY);
+        drawW = static_cast<int32_t>(bmpW * scale);
+        drawH = static_cast<int32_t>(bmpH * scale);
+      }
+
+      int32_t xOffset = (screenW - drawW) / 2;
+      int32_t yOffset = (screenH - drawH) / 2;
+
+      renderer.drawBitmap(bmp, xOffset, yOffset, drawW, drawH);

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/activities/util/BmpViewerActivity.cpp` around lines 26 - 33, The code
currently centers the BMP using xOffset/yOffset and bmpW/bmpH but does not scale
images larger than the screen, causing clipping; modify the drawing logic
(around renderer.drawBitmap) to compute a scale = min(1.0,
renderer.getScreenWidth() / float(bmpW), renderer.getScreenHeight() /
float(bmpH)) to preserve aspect ratio, then set drawW = int(bmpW * scale), drawH
= int(bmpH * scale), recalc xOffset/yOffset using drawW/drawH to center, and
call renderer.drawBitmap(bmp, xOffset, yOffset, drawW, drawH) so large images
are downscaled to fit while small images remain unscaled.

---

43-44: Consider localizing the "« Back" button label.

Other activities use the tr() function for button labels (e.g., tr(STR_BACK) in MyLibraryActivity.cpp). For consistency and internationalization support, this hardcoded string should use the localization system.

💬 Proposed fix

Add the I18n include and use the localized string:

+#include <I18n.h>

-  const auto labels = mappedInput.mapLabels("« Back", "", "", "");
+  const auto labels = mappedInput.mapLabels(tr(STR_BACK), "", "", "");

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/activities/util/BmpViewerActivity.cpp` around lines 43 - 44, The
hardcoded "« Back" label passed to mappedInput.mapLabels should be replaced with
the localized string using tr(STR_BACK); update the include list to pull in the
I18n header (so tr/STR_BACK are available), then call
mappedInput.mapLabels(tr(STR_BACK), "", "", ""); keep the rest
(GUI.drawButtonHints(renderer, labels.btn1, labels.btn2, labels.btn3,
labels.btn4)) unchanged to preserve behavior.

src/activities/reader/ReaderActivity.cpp (1)

94-97: currentBookPath is not updated for BMP files.

Other reader navigation methods (e.g., onGoToEpubReader, onGoToXtcReader, onGoToTxtReader) update currentBookPath before transitioning. This is skipped for BMP files. While BMP is not a "book," consider if consistency is desired for any tracking or navigation purposes.

💡 Optional: Set currentBookPath for consistency

 void ReaderActivity::onGoToBmpViewer(const std::string& path) {
+  currentBookPath = path;
   exitActivity();
   enterNewActivity(new BmpViewerActivity(renderer, mappedInput, path, [this, path] { goToLibrary(path); }));
 }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/activities/reader/ReaderActivity.cpp` around lines 94 - 97, The
onGoToBmpViewer path transition doesn't set currentBookPath like the other
readers; update currentBookPath (e.g., assign currentBookPath = path) before
calling exitActivity()/enterNewActivity so the BmpViewerActivity transition
behaves consistently with onGoToEpubReader/onGoToXtcReader/onGoToTxtReader and
any navigation/tracking logic that relies on currentBookPath (affecting symbols:
onGoToBmpViewer, currentBookPath, exitActivity, enterNewActivity,
BmpViewerActivity, goToLibrary).

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Learnt from: Levrk
Repo: crosspoint-reader/crosspoint-reader PR: 909
File: src/activities/reader/EpubReaderActivity.cpp:461-461
Timestamp: 2026-02-16T20:43:19.339Z
Learning: In src/activities/reader/EpubReaderActivity.cpp, when using ConfirmationActivity with enterNewActivity(), it's not necessary to call exitActivity() beforehand. The ConfirmationActivity operates as a modal dialog and cleanup is handled via the pendingSubactivityExit flag in the callback lambda. This differs from other activities like EpubReaderChapterSelectionActivity or KOReaderSyncActivity which do require exitActivity() before enterNewActivity().