feat: Allow a local configuration file for custom compiles#879
Merged
daveallie merged 3 commits intocrosspoint-reader:masterfrom Feb 22, 2026
Merged
feat: Allow a local configuration file for custom compiles#879daveallie merged 3 commits intocrosspoint-reader:masterfrom
daveallie merged 3 commits intocrosspoint-reader:masterfrom
Conversation
osteotek
previously approved these changes
Feb 14, 2026
Contributor
|
I'm fine with this if |
jdk2pq
previously approved these changes
Feb 15, 2026
osteotek
previously approved these changes
Feb 20, 2026
daveallie
approved these changes
Feb 22, 2026
Contributor
📝 WalkthroughWalkthroughConfiguration updates enabling support for local per-user settings. Added a gitignore pattern for Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.gitignore (1)
15-15: Consider narrowing the ignore pattern to avoid overreach.
*.local*can unintentionally ignore unrelated files (e.g., localization assets or files containing “local” in the name). If the intent is only to ignore the PlatformIO local config, consider a narrower pattern likeplatformio.local.ini(or*.local.iniif you expect multiple local INI files).🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.gitignore at line 15, The gitignore entry '*.local*' is too broad and may hide unrelated files; replace it with a narrower pattern that targets the intended PlatformIO local config (for example use 'platformio.local.ini' or '*.local.ini' instead of '*.local*') so only local INI files are ignored while leaving other files containing "local" visible.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.gitignoreplatformio.ini
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: cppcheck
- GitHub Check: build
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.gitignore:
- Line 15: The gitignore entry '*.local*' is too broad and may hide unrelated
files; replace it with a narrower pattern that targets the intended PlatformIO
local config (for example use 'platformio.local.ini' or '*.local.ini' instead of
'*.local*') so only local INI files are ignored while leaving other files
containing "local" visible.
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 22, 2026
…t-reader#879) ## Summary * platformio.ini is a repository based config for platformio and cannot be modified without constant nagging of git to include it into you commits * PlatformIO allows you to split your configuration into multiple files using the extra_configs option in the [platformio] block. This effectively merges other .ini files into your main one. This will be silently ignored if such a file does not exist ## Additional Context * Modifiy platformio.ini and add a .gitignore entry to ignore your local config * eg my own ``platformio.local.ini``: ``` [env:custom] extends = base build_flags = ${base.build_flags} -DCROSSPOINT_VERSION=\"${crosspoint.version}-custom\" ; inclusion of additional fonts is disabled in custom builds to save space -DOMIT_FONTS ``` --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _NO_ --------- Co-authored-by: Dave Allie <[email protected]>
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 22, 2026
…t-reader#879) ## Summary * platformio.ini is a repository based config for platformio and cannot be modified without constant nagging of git to include it into you commits * PlatformIO allows you to split your configuration into multiple files using the extra_configs option in the [platformio] block. This effectively merges other .ini files into your main one. This will be silently ignored if such a file does not exist ## Additional Context * Modifiy platformio.ini and add a .gitignore entry to ignore your local config * eg my own ``platformio.local.ini``: ``` [env:custom] extends = base build_flags = ${base.build_flags} -DCROSSPOINT_VERSION=\"${crosspoint.version}-custom\" ; inclusion of additional fonts is disabled in custom builds to save space -DOMIT_FONTS ``` --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _NO_ --------- Co-authored-by: Dave Allie <[email protected]>
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 22, 2026
…t-reader#879) ## Summary * platformio.ini is a repository based config for platformio and cannot be modified without constant nagging of git to include it into you commits * PlatformIO allows you to split your configuration into multiple files using the extra_configs option in the [platformio] block. This effectively merges other .ini files into your main one. This will be silently ignored if such a file does not exist ## Additional Context * Modifiy platformio.ini and add a .gitignore entry to ignore your local config * eg my own ``platformio.local.ini``: ``` [env:custom] extends = base build_flags = ${base.build_flags} -DCROSSPOINT_VERSION=\"${crosspoint.version}-custom\" ; inclusion of additional fonts is disabled in custom builds to save space -DOMIT_FONTS ``` --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _NO_ --------- Co-authored-by: Dave Allie <[email protected]>
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 22, 2026
…t-reader#879) ## Summary * platformio.ini is a repository based config for platformio and cannot be modified without constant nagging of git to include it into you commits * PlatformIO allows you to split your configuration into multiple files using the extra_configs option in the [platformio] block. This effectively merges other .ini files into your main one. This will be silently ignored if such a file does not exist ## Additional Context * Modifiy platformio.ini and add a .gitignore entry to ignore your local config * eg my own ``platformio.local.ini``: ``` [env:custom] extends = base build_flags = ${base.build_flags} -DCROSSPOINT_VERSION=\"${crosspoint.version}-custom\" ; inclusion of additional fonts is disabled in custom builds to save space -DOMIT_FONTS ``` --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _NO_ --------- Co-authored-by: Dave Allie <[email protected]>
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 22, 2026
…t-reader#879) ## Summary * platformio.ini is a repository based config for platformio and cannot be modified without constant nagging of git to include it into you commits * PlatformIO allows you to split your configuration into multiple files using the extra_configs option in the [platformio] block. This effectively merges other .ini files into your main one. This will be silently ignored if such a file does not exist ## Additional Context * Modifiy platformio.ini and add a .gitignore entry to ignore your local config * eg my own ``platformio.local.ini``: ``` [env:custom] extends = base build_flags = ${base.build_flags} -DCROSSPOINT_VERSION=\"${crosspoint.version}-custom\" ; inclusion of additional fonts is disabled in custom builds to save space -DOMIT_FONTS ``` --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _NO_ --------- Co-authored-by: Dave Allie <[email protected]>
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 22, 2026
…t-reader#879) ## Summary * platformio.ini is a repository based config for platformio and cannot be modified without constant nagging of git to include it into you commits * PlatformIO allows you to split your configuration into multiple files using the extra_configs option in the [platformio] block. This effectively merges other .ini files into your main one. This will be silently ignored if such a file does not exist ## Additional Context * Modifiy platformio.ini and add a .gitignore entry to ignore your local config * eg my own ``platformio.local.ini``: ``` [env:custom] extends = base build_flags = ${base.build_flags} -DCROSSPOINT_VERSION=\"${crosspoint.version}-custom\" ; inclusion of additional fonts is disabled in custom builds to save space -DOMIT_FONTS ``` --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _NO_ --------- Co-authored-by: Dave Allie <[email protected]>
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 22, 2026
…t-reader#879) ## Summary * platformio.ini is a repository based config for platformio and cannot be modified without constant nagging of git to include it into you commits * PlatformIO allows you to split your configuration into multiple files using the extra_configs option in the [platformio] block. This effectively merges other .ini files into your main one. This will be silently ignored if such a file does not exist ## Additional Context * Modifiy platformio.ini and add a .gitignore entry to ignore your local config * eg my own ``platformio.local.ini``: ``` [env:custom] extends = base build_flags = ${base.build_flags} -DCROSSPOINT_VERSION=\"${crosspoint.version}-custom\" ; inclusion of additional fonts is disabled in custom builds to save space -DOMIT_FONTS ``` --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _NO_ --------- Co-authored-by: Dave Allie <[email protected]>
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 22, 2026
…t-reader#879) ## Summary * platformio.ini is a repository based config for platformio and cannot be modified without constant nagging of git to include it into you commits * PlatformIO allows you to split your configuration into multiple files using the extra_configs option in the [platformio] block. This effectively merges other .ini files into your main one. This will be silently ignored if such a file does not exist ## Additional Context * Modifiy platformio.ini and add a .gitignore entry to ignore your local config * eg my own ``platformio.local.ini``: ``` [env:custom] extends = base build_flags = ${base.build_flags} -DCROSSPOINT_VERSION=\"${crosspoint.version}-custom\" ; inclusion of additional fonts is disabled in custom builds to save space -DOMIT_FONTS ``` --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _NO_ --------- Co-authored-by: Dave Allie <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Additional Context
platformio.local.ini:AI Usage
While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.
Did you use AI tools to help write this code? NO