fix: Implement guide-based cover image fallback#830
Merged
daveallie merged 4 commits intocrosspoint-reader:masterfrom Feb 16, 2026
Merged
fix: Implement guide-based cover image fallback#830daveallie merged 4 commits intocrosspoint-reader:masterfrom
daveallie merged 4 commits intocrosspoint-reader:masterfrom
Conversation
Extract cover image reference from guide's cover page XHTML when metadata cover is not found
This was referenced Feb 11, 2026
daveallie
previously approved these changes
Feb 16, 2026
Member
daveallie
left a comment
daveallie
left a comment
There was a problem hiding this comment.
Looks good, just needs a rebase.
Unintendedsideeffects
pushed a commit
to Unintendedsideeffects/crosspoint-reader
that referenced
this pull request
Feb 17, 2026
This partially fixes crosspoint-reader#769 but is dependent upon PR crosspoint-reader#827 being merged along side this @daveallie. I removed my PNG conversion code after finding out that PR was already created. Without this PR though that book in crosspoint-reader#769 will still fail to load because of how it's stored in the file --------- Co-authored-by: Dave Allie <[email protected]>
saslv
pushed a commit
to saslv/crosspoint-reader
that referenced
this pull request
Feb 19, 2026
This partially fixes crosspoint-reader#769 but is dependent upon PR crosspoint-reader#827 being merged along side this @daveallie. I removed my PNG conversion code after finding out that PR was already created. Without this PR though that book in crosspoint-reader#769 will still fail to load because of how it's stored in the file --------- Co-authored-by: Dave Allie <[email protected]>
el
pushed a commit
to el/crosspoint-reader
that referenced
this pull request
Feb 19, 2026
This partially fixes crosspoint-reader#769 but is dependent upon PR crosspoint-reader#827 being merged along side this @daveallie. I removed my PNG conversion code after finding out that PR was already created. Without this PR though that book in crosspoint-reader#769 will still fail to load because of how it's stored in the file --------- Co-authored-by: Dave Allie <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This partially fixes #769 but is dependent upon PR #827 being merged along side this @daveallie. I removed my PNG conversion code after finding out that PR was already created. Without this PR though that book in #769 will still fail to load because of how it's stored in the file