fix: Manually trigger GPIO update in File Browser mode#819
Merged
Conversation
Member
Author
|
@coderabbitai review |
Contributor
✅ Actions performedReview triggered.
|
Contributor
📝 WalkthroughWalkthroughAdds input state refreshing capability to the MappedInputManager with a new const update() method and integrates periodic input polling into the network web server activity loop to enable more responsive button detection during file transfer operations. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@src/activities/network/CrossPointWebServerActivity.cpp`:
- Around line 351-353: The comment above the mappedInput.update() call contains
a typo; change "so be have accurate stat" to "so we have accurate state" so the
comment reads: "Force trigger an update of which buttons are being pressed so we
have accurate state for back button checking" while leaving the
mappedInput.update() call unchanged.
🧹 Nitpick comments (1)
src/MappedInputManager.h (1)
18-18: Consider removingconstqualifier for semantic clarity.While this compiles (calling non-const methods on a reference member from a const method is allowed in C++), marking
update()asconstis semantically misleading since it triggers side effects by updating GPIO/input state. The otherconstmethods in this class (wasPressed,wasReleased, etc.) are pure queries, butupdate()mutates external state.If
mappedInputis not held as a const reference in the calling code, consider removing theconstqualifier for clearer intent.Suggested change
- void update() const { gpio.update(); } + void update() { gpio.update(); }
Contributor
|
Testing on device and quick clicks of the "Exit" button seem more reliably detected in both "Network Transfer" and "Hotspot Mode" screens. I noticed that one time, clicking exit in the hotspot mode caused the device to reboot rather than just return home, but I can't reproduce that. |
lukestein
approved these changes
Feb 10, 2026
Contributor
lukestein
left a comment
lukestein
left a comment
There was a problem hiding this comment.
Testing on device (no code review). Seems effective!
osteotek
approved these changes
Feb 11, 2026
jdk2pq
added a commit
to jdk2pq/crosspoint-reader
that referenced
this pull request
Feb 12, 2026
…king-space * master: fix: chore: make all debug messages uniform (crosspoint-reader#825) fix: Show "Back" in file browser if not in root, "Home" otherwise. (crosspoint-reader#822) fix: Manually trigger GPIO update in File Browser mode (crosspoint-reader#819)
jdk2pq
added a commit
to jdk2pq/crosspoint-reader
that referenced
this pull request
Feb 13, 2026
* master: fix: chore: make all debug messages uniform (crosspoint-reader#825) fix: Show "Back" in file browser if not in root, "Home" otherwise. (crosspoint-reader#822) fix: Manually trigger GPIO update in File Browser mode (crosspoint-reader#819)
anthonydgallo
added a commit
to anthonydgallo/crosspoint-reader
that referenced
this pull request
Feb 16, 2026
fix: Manually trigger GPIO update in File Browser mode (crosspoint-reader#819)
Unintendedsideeffects
pushed a commit
to Unintendedsideeffects/crosspoint-reader
that referenced
this pull request
Feb 17, 2026
…ader#819) ## Summary * Manually trigger GPIO update in File Browser mode * Previously just assumed that the GPIO data would update automatically (presumably via yield), the data is currently updated in the main loop (and now here as well during the middle of the processing loop). * This allows the back button to be correctly detected instead of only being checked once every 100ms or so for the button state. ## Additional Context * Fixes crosspoint-reader#579 --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Enhanced input state detection in the web server interface for more responsive and accurate user command recognition during high-frequency operations. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
saslv
pushed a commit
to saslv/crosspoint-reader
that referenced
this pull request
Feb 19, 2026
…ader#819) ## Summary * Manually trigger GPIO update in File Browser mode * Previously just assumed that the GPIO data would update automatically (presumably via yield), the data is currently updated in the main loop (and now here as well during the middle of the processing loop). * This allows the back button to be correctly detected instead of only being checked once every 100ms or so for the button state. ## Additional Context * Fixes crosspoint-reader#579 --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? No <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Enhanced input state detection in the web server interface for more responsive and accurate user command recognition during high-frequency operations. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Additional Context
AI Usage
While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.
Did you use AI tools to help write this code? No
Summary by CodeRabbit