fix: Reduce MIN_SIZE_FOR_POPUP to 10KB#809
Conversation
Noticed that the Indexing... popup went missing despite 3-5 seconds delay. Reducing to 10KB, so we get a popup for delays > ~2s.
|
Requesting @osteotek review since I think maybe he was the one who cut out some of these popups since they took a while to draw? |
|
Agree that I've had a handful of cases where the delay was large without feedback, keen to tighten this up as you've done, but also happy for @osteotek to weigh in |
|
yes, with recent additions feels like chapter rendering time increased, so this timeout needs to be tightened up. But maybe set it to 20kb? |
I tried 20kb first, still got "unpleasant" delays with ca 13kB file, so I decided to go down to 10. A 6kB file I tried still had noticable delay, but by the time you're wondering if the device is stuck, the delay was over. So I figured 10kB works well at the moment. |
I'm fine with 10kb too. It's just for small chapters that means time to text refresh increased by more than x2, just the fact of having to render popup becomes the biggest bottleneck. So we need to decide what is more unpleasant: increased time to render new chapter or smaller time but with no feedback |
|
Just did some testing, opening same chapter size 18kb, time to first text:
so not much of a difference as I thought. Setting to 10 kb is probably good threshold |
…king-space * master: fix: Reduce MIN_SIZE_FOR_POPUP to 10KB (crosspoint-reader#809) docs: Update USER_GUIDE.md (crosspoint-reader#817) fix: Prevent sleeping when in OPDS browser / downloading books (crosspoint-reader#818) feat: Extend python debugging monitor functionality (keyword filter / suppress) (crosspoint-reader#810) docs: Update USER_GUIDE.md (crosspoint-reader#808) feat: Connect to last wifi by default (crosspoint-reader#752)
* master: (25 commits) fix: Reduce MIN_SIZE_FOR_POPUP to 10KB (crosspoint-reader#809) docs: Update USER_GUIDE.md (crosspoint-reader#817) fix: Prevent sleeping when in OPDS browser / downloading books (crosspoint-reader#818) feat: Extend python debugging monitor functionality (keyword filter / suppress) (crosspoint-reader#810) docs: Update USER_GUIDE.md (crosspoint-reader#808) feat: Connect to last wifi by default (crosspoint-reader#752) feat: use natural sort in file browser (crosspoint-reader#722) fix: issue if book href are absolute url and not relative to server (crosspoint-reader#741) feat: unify navigation handling with system-wide continuous navigation (crosspoint-reader#600) feat: Add Italian hyphenation support (crosspoint-reader#584) feat: Add percentage support to CSS properties (crosspoint-reader#738) Use GITHUB_REF_NAME over GITHUB_HEAD_REF in release candidate workflow Move release candidate workflow to manual dispatch fix: Allow OTA update from RC build to full release (crosspoint-reader#778) refactor: Rename "Embedded Style" to "Book's Embedded Style" (crosspoint-reader#746) perf: optimize drawPixel() (crosspoint-reader#748) feat: wakeup target detection (crosspoint-reader#731) fix: Scrolling page items calculation (crosspoint-reader#716) feat: optimize fillRectDither (crosspoint-reader#737) fix: increase lyra sideButtonHintsWidth to 30 (crosspoint-reader#727) ...
Noticed that the Indexing... popup went missing despite 3-5 seconds delay. Reducing to 10KB, so we get a popup for delays > ~2s. ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? no
5 participants
Noticed that the Indexing... popup went missing despite 3-5 seconds delay. Reducing to 10KB, so we get a popup for delays > ~2s.
AI Usage
While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.
Did you use AI tools to help write this code? no