fix(epub): avoid crashes when CSS cache is missing#762
Open
DChells wants to merge 5 commits intocrosspoint-reader:masterfrom
Open
fix(epub): avoid crashes when CSS cache is missing#762DChells wants to merge 5 commits intocrosspoint-reader:masterfrom
DChells wants to merge 5 commits intocrosspoint-reader:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevents EPUB reader reboot loops when
css_rules.cacheis missing, and stops Home from repeatedly retrying cover thumbnail generation for unsupported EPUB cover images.Fixes #761.
Problem
Two issues that show up most often on ESP32-C3 with large EPUBs:
/.crosspoint/epub_<hash>/css_rules.cacheis missing, we try to parse CSS on-demand.thumb_<height>.bmpfor recent book covers.37/PJPG_UNSUPPORTED_MODE).Solution
Notes / tradeoffs
Testing
On hardware (Xteink X4 / ESP32-C3):
/.crosspoint/epub_<hash>/css_rules.cachefor a large EPUB, then open it → should not reboot; should log skipping CSS parseFiles changed
lib/Epub/Epub.cppsrc/RecentBooksStore.cppsrc/components/themes/lyra/LyraTheme.cpp