fix: Add EPUB 3 cover image detection#760
Merged
daveallie merged 1 commit intocrosspoint-reader:masterfrom Feb 8, 2026
Merged
Conversation
itsthisjustin
changed the title
el
reviewed
Feb 8, 2026
|
|
||
| // EPUB 3: Check for cover image (properties contains "cover-image") | ||
| if (!properties.empty() && self->coverItemHref.empty()) { | ||
| if (properties == "cover-image" || properties.find("cover-image ") == 0 || |
Contributor
There was a problem hiding this comment.
Is the empty space after cover-image by mistake?
Contributor
Author
There was a problem hiding this comment.
Is the empty space after cover-image by mistake?
No apparently epub 3 uses space separated values for properties so this is an easy way to catch the cover image no matter where it shows in the list
daveallie
approved these changes
Feb 8, 2026
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 8, 2026
I had an epub that just showed a blank cover and wouldnt work for the sleep screen either, turns out it was an epub3 and I guess we didn't support that. Super simple fix here
jdk2pq
added a commit
to jdk2pq/crosspoint-reader
that referenced
this pull request
Feb 9, 2026
…king-space * master: feat: Add percentage support to CSS properties (crosspoint-reader#738) Use GITHUB_REF_NAME over GITHUB_HEAD_REF in release candidate workflow Add release candidate workflow fix: Allow OTA update from RC build to full release (crosspoint-reader#778) fix(ui): Add Back label in KOReader Sync screen (crosspoint-reader#770) fix: Add EPUB 3 cover image detection (crosspoint-reader#760) feat: A web editor for settings (crosspoint-reader#667) feat: add HalStorage (crosspoint-reader#656) perf: optimize drawPixel() (crosspoint-reader#748) feat: wakeup target detection (crosspoint-reader#731) fix: Scrolling page items calculation (crosspoint-reader#716) refactor: Rename "Embedded Style" to "Book's Embedded Style" (crosspoint-reader#746) feat: optimize fillRectDither (crosspoint-reader#737)
Marma92
pushed a commit
to Marma92/crosspoint-reader
that referenced
this pull request
Feb 10, 2026
I had an epub that just showed a blank cover and wouldnt work for the sleep screen either, turns out it was an epub3 and I guess we didn't support that. Super simple fix here
Unintendedsideeffects
pushed a commit
to Unintendedsideeffects/crosspoint-reader
that referenced
this pull request
Feb 17, 2026
I had an epub that just showed a blank cover and wouldnt work for the sleep screen either, turns out it was an epub3 and I guess we didn't support that. Super simple fix here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had an epub that just showed a blank cover and wouldnt work for the sleep screen either, turns out it was an epub3 and I guess we didn't support that. Super simple fix here