I liked the idea of a more customizable status bar, but the settings look to crowded this way. I think we need settings grouping first.

I liked the idea of a more customizable status bar, but the settings look to crowded this way. I think we need settings grouping first.

Absolutely agree - I think a separate menu activity (such as the one we use for KOReader Sync) would be the best route, with a preview of what the menu bar would look like. As a (very) rough example:

This PR so far does the very basics, updating the code to split the status bar settings, but I didn't want to pursue any UI changes without some feedback first - I do think we need those changes before we merge this PR, though 🙂

New update! Settings have been moved to a separate menu, found in the Reader sub-menu.

In my view, the following tasks remain:

• I've noticed the names of the buttons are inconsistent - I'll update these to match settings.
• Battery % for status bar should be part of this menu, rather than where it is currently.
• Pulling the render behaviour from txt & epub and creating a utility to draw it instead. This can then be used to render an example status bar in the status bar menu.
• Remove old status bar setting from page.

Thank you, it looks nice with this kind of preview. Small things:

Display Book Progress Bar missing,

• Display Book Progress Bar: OFF / Thin (2px) / Medium (4px) (default) / Thick (6px)

This is a small setting for those who want it. It works as before by default.

You can also implement the setting called Progress Bar Fill Edges, useful for black devices. It is also a simple one line fix:

#570 (comment)

Remap Front Buttons panel has a button called Remap Front Buttons

Status Bar Settings panel has a button called just Status Bar (inconsistent)

Progress Bar → Book naming feels off. In my initial Issue I used titles as close to the original as possible

And it should probably say Display ___ like before. You used Show for the battery because it feels short, but same goes with the rest: it's just Chapter Title (inconsistent)

Other than that, this page looks really good

Display Book Progress Bar: OFF / Thin (2px) / Medium (4px) (default) / Thick (6px)
This is a small setting for those who want it. It works as before by default.

Currently working on this now - is this a highly sought after feature? I'm weary that we don't want too add too many small settings, as we could end up with hundreds of those! Happy for Dave/a collaborator to weigh in before the merge on that, though.

You can also implement the setting called Progress Bar Fill Edges, useful for black devices. It is also a simple one line fix:

I don't know enough about this issue - looks like from the discussions the fill could be better as a fix rather than a new setting?

Progress Bar → Book naming feels off. In my initial Issue I used titles as close to the original as possible
And it should probably say Display ___ like before. You used Show for the battery because it feels short, but same goes with the rest: it's just Chapter Title (inconsistent)

They're intended to match (more or less) to the naming structure of the rest of the settings - the majority have the target as the name and the action as the option (think Paragraph Alignment -> Justify rather than Align Paragraph -> Justified). I do agree that it needs a little update (thanks!), so I've changed the options to verbs b423319

Remap Front Buttons panel has a button called Remap Front Buttons
Status Bar Settings panel has a button called just Status Bar (inconsistent)

Good point - I've updated to "Customise Status Bar" as that feels like it would be suitable for both places 65dc63f

Thanks for your feedback! 🙂

Bar thickness is not a small setting, in horizontal mode on a white model the default line looks too thick #602 and distracting, not how it was intended (it looks normal in vertical mode). And border fill will look even thicker on a white model.

The two new settings inside a specific subpage don't affect the basic experience at all, it works like before by default. And these settings actually improve the experience, as they provide a decent solution for black devices without ruining the visual appearance of white devices. This is literally taking everyone's interests into account, rather than trying to create a uniform experience for everyone.

Bar thickness is not a small setting, in horizontal mode on a white model the default line looks too thick #602 and distracting, not how it was intended (it looks normal in vertical mode). And border fill will look even thicker on a white model.

The two new settings inside a specific subpage don't affect the basic experience at all, it works like before by default. And these settings actually improve the experience, as they provide a decent solution for black devices without ruining the visual appearance of white devices. This is literally taking everyone's interests into account, rather than trying to create a uniform experience for everyone.

Ah - got you. In that case I agree, although that does make the preview rather redundant for this setting, given the use case. I think we may have to just accept that, though - unless anyone has suggestions?

It's as if you're overthinking the settings without prioritizing actual reading experience. Navigating through this settings section will take up 1% of the user's time. But the other 99% of the time:

• Users of black e-readers will see big status bar margins or they won't use it at all
• Users of white e-readers in portrait orientation are fine
• Users of white e-readers in landscape orientation see a thicker bar that is distracting

I'm fine with the case where, after reading in horizontal mode I see a thick bar and go to Settings → change the thickness.
Yes, the preview is only for the vertical one, but I know what I'm changing, and the preview wasn't here before anyway.

It's as if you're overthinking the settings without prioritizing actual reading experience.

@Eloren1 you've been told again and again. Please stop with accusatory language. It's not welcome in this community

It's as if you're overthinking the settings without prioritizing actual reading experience.

@Eloren1 you've been told again and again. Please stop with accusatory language. It's not welcome in this community

And for what it's worth - I was agreeing with you. I think we may have to just accept that the user will have to flick back and fourth a couple times if they want to check what it looks like for them

accusatory

You're giving meaning to words that weren't meant to be, interrupting the discussion.

It seems there's already a bias towards my words. Although it would be better not to forget the "Human First" Rule.

flick back and fourth a couple times if they want to check what it looks like for them

Haha that's generally how it was before. But now at least 90% of the items will be available for preview in real time

Do you think it is possible to add an option for decimals for book progress? I think it was a bug back in Crosspoint 0.15 and got fixed but I really grew to like it.

@whyte-j Would it be possible to fix conflicts? Keen to merge this

@whyte-j Would it be possible to fix conflicts? Keen to merge this

Happy to hear it! Will try and get it sorted this evening 🙂

As for the bar thickness @Eloren1, if we're eager to get this merged I can take a look at doing that in a follow up PR, as it won't need to use the legacy setting transformation. I got a couple of odd bugs that I haven't had the chance to squash just yet

@osteotek all sorted!