feat: wakeup target detection#731
Merged
daveallie merged 2 commits intocrosspoint-reader:masterfrom Feb 8, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR implements wakeup target detection to improve the user experience when waking from sleep. The device now tracks whether it went to sleep from the reader view and uses this information to determine the appropriate wakeup destination.
Changes:
- Added
lastSleepFromReaderboolean flag to track sleep origin - Introduced
isReaderActivity()virtual method to identify reader activities - Modified wakeup logic to consider both the presence of an open book and the sleep origin
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/CrossPointState.h | Added lastSleepFromReader boolean field to state |
| src/CrossPointState.cpp | Bumped state file version to 4, added serialization for lastSleepFromReader with backward compatibility |
| src/activities/Activity.h | Added virtual isReaderActivity() method returning false by default |
| src/activities/reader/ReaderActivity.h | Overrode isReaderActivity() to return true for reader activities |
| src/main.cpp | Set lastSleepFromReader on sleep, added it to wakeup condition check |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Could this be extended to effectively implement deep sleep during reading? As in a flow of:
It would effectively save a lot of battery life for the use case of reading |
Member
Author
Yeah, I thought of something similar. But the only way to wake up from deepsleep is the power button, that's how the device is wired. And waking up can take up to a second, not really suitable for reading |
lukestein
approved these changes
Feb 6, 2026
Contributor
lukestein
left a comment
lukestein
left a comment
There was a problem hiding this comment.
No code review conducted, but tested on device, and seems to work exactly as expected.
Thank you! 🎉 A nice little bit of UX polish.
jdk2pq
approved these changes
Feb 7, 2026
Contributor
jdk2pq
left a comment
jdk2pq
left a comment
There was a problem hiding this comment.
LGTM! I left one minor, non-blocking comment for consideration, but I'm totally fine with resolving it as is too. Great job!
| // Enter deep sleep mode | ||
| void enterDeepSleep() { | ||
| APP_STATE.lastSleepFromReader = currentActivity && currentActivity->isReaderActivity(); | ||
| APP_STATE.saveToFile(); |
Contributor
There was a problem hiding this comment.
minor, non-blocking: saveToFile() returns a bool that could be checked and have some kind of Serial debug statement about not being able to save the APP_STATE. But that's not currently a pattern we follow anywhere else saveToFile or loadFromFile gets called, so I'm completely fine with leaving this as is too.
CaptainFrito
approved these changes
Feb 8, 2026
daveallie
approved these changes
Feb 8, 2026
daveallie
pushed a commit
that referenced
this pull request
Feb 8, 2026
## Summary * If going to sleep was from the Reader view, wake up to the same book. Otherwise, wakeup to the Home view
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 8, 2026
## Summary * If going to sleep was from the Reader view, wake up to the same book. Otherwise, wakeup to the Home view
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 8, 2026
## Summary * If going to sleep was from the Reader view, wake up to the same book. Otherwise, wakeup to the Home view
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 8, 2026
## Summary * If going to sleep was from the Reader view, wake up to the same book. Otherwise, wakeup to the Home view
jdk2pq
added a commit
to jdk2pq/crosspoint-reader
that referenced
this pull request
Feb 9, 2026
…king-space * master: feat: Add percentage support to CSS properties (crosspoint-reader#738) Use GITHUB_REF_NAME over GITHUB_HEAD_REF in release candidate workflow Add release candidate workflow fix: Allow OTA update from RC build to full release (crosspoint-reader#778) fix(ui): Add Back label in KOReader Sync screen (crosspoint-reader#770) fix: Add EPUB 3 cover image detection (crosspoint-reader#760) feat: A web editor for settings (crosspoint-reader#667) feat: add HalStorage (crosspoint-reader#656) perf: optimize drawPixel() (crosspoint-reader#748) feat: wakeup target detection (crosspoint-reader#731) fix: Scrolling page items calculation (crosspoint-reader#716) refactor: Rename "Embedded Style" to "Book's Embedded Style" (crosspoint-reader#746) feat: optimize fillRectDither (crosspoint-reader#737)
Marma92
pushed a commit
to Marma92/crosspoint-reader
that referenced
this pull request
Feb 10, 2026
## Summary * If going to sleep was from the Reader view, wake up to the same book. Otherwise, wakeup to the Home view
jdk2pq
added a commit
to jdk2pq/crosspoint-reader
that referenced
this pull request
Feb 11, 2026
…king-space * master: feat: use natural sort in file browser (crosspoint-reader#722) fix: issue if book href are absolute url and not relative to server (crosspoint-reader#741) feat: unify navigation handling with system-wide continuous navigation (crosspoint-reader#600) feat: Add Italian hyphenation support (crosspoint-reader#584) feat: Add percentage support to CSS properties (crosspoint-reader#738) Use GITHUB_REF_NAME over GITHUB_HEAD_REF in release candidate workflow Move release candidate workflow to manual dispatch fix: Allow OTA update from RC build to full release (crosspoint-reader#778) refactor: Rename "Embedded Style" to "Book's Embedded Style" (crosspoint-reader#746) perf: optimize drawPixel() (crosspoint-reader#748) feat: wakeup target detection (crosspoint-reader#731) fix: Scrolling page items calculation (crosspoint-reader#716) feat: optimize fillRectDither (crosspoint-reader#737) fix: increase lyra sideButtonHintsWidth to 30 (crosspoint-reader#727) fix: Remove separations after style changes (crosspoint-reader#720) fix: Lag before displaying covers on home screen (crosspoint-reader#721) feat: Add Settings for toggling CSS on or off (crosspoint-reader#717) Use GITHUB_HEAD_REF release: 1.0.0
jdk2pq
added a commit
to jdk2pq/crosspoint-reader
that referenced
this pull request
Feb 13, 2026
* master: (25 commits) fix: Reduce MIN_SIZE_FOR_POPUP to 10KB (crosspoint-reader#809) docs: Update USER_GUIDE.md (crosspoint-reader#817) fix: Prevent sleeping when in OPDS browser / downloading books (crosspoint-reader#818) feat: Extend python debugging monitor functionality (keyword filter / suppress) (crosspoint-reader#810) docs: Update USER_GUIDE.md (crosspoint-reader#808) feat: Connect to last wifi by default (crosspoint-reader#752) feat: use natural sort in file browser (crosspoint-reader#722) fix: issue if book href are absolute url and not relative to server (crosspoint-reader#741) feat: unify navigation handling with system-wide continuous navigation (crosspoint-reader#600) feat: Add Italian hyphenation support (crosspoint-reader#584) feat: Add percentage support to CSS properties (crosspoint-reader#738) Use GITHUB_REF_NAME over GITHUB_HEAD_REF in release candidate workflow Move release candidate workflow to manual dispatch fix: Allow OTA update from RC build to full release (crosspoint-reader#778) refactor: Rename "Embedded Style" to "Book's Embedded Style" (crosspoint-reader#746) perf: optimize drawPixel() (crosspoint-reader#748) feat: wakeup target detection (crosspoint-reader#731) fix: Scrolling page items calculation (crosspoint-reader#716) feat: optimize fillRectDither (crosspoint-reader#737) fix: increase lyra sideButtonHintsWidth to 30 (crosspoint-reader#727) ...
Unintendedsideeffects
pushed a commit
to Unintendedsideeffects/crosspoint-reader
that referenced
this pull request
Feb 17, 2026
## Summary * If going to sleep was from the Reader view, wake up to the same book. Otherwise, wakeup to the Home view
Unintendedsideeffects
pushed a commit
to Unintendedsideeffects/crosspoint-reader
that referenced
this pull request
Feb 17, 2026
## Summary * If going to sleep was from the Reader view, wake up to the same book. Otherwise, wakeup to the Home view
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary