feat(ux): invert BACK button behavior in reader activities#726
Merged
lukestein merged 1 commit intocrosspoint-reader:masterfrom Feb 7, 2026
Merged
Conversation
osteotek
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR inverts the BACK button behavior in all reader activities to make short press go to home and long press go to file selection, which is more intuitive given that recent books are now displayed on the home screen.
Changes:
- Swapped the functionality of short and long BACK button presses in reader activities
- Updated code comments to accurately reflect the new behavior
- Applied changes consistently across all three reader activity types (EPUB, TXT, XTC)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/activities/reader/XtcReaderActivity.cpp | Inverted BACK button behavior: short press now goes to home, long press to file browser |
| src/activities/reader/TxtReaderActivity.cpp | Inverted BACK button behavior: short press now goes to home, long press to file browser |
| src/activities/reader/EpubReaderActivity.cpp | Inverted BACK button behavior: short press now goes to home, long press to file browser |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
CaptainFrito
approved these changes
Feb 6, 2026
lukestein
approved these changes
Feb 6, 2026
andrewb1269
approved these changes
Feb 6, 2026
Member
There was a problem hiding this comment.
Comment: the if-checks are now backwards.
getHeldTime() >= goHomeMs --> goBack
getHeldTime() < goHomeMs --> goHome
I would expect heldTime > goHome time would result in going home instead of going back. This is a variable naming situation that I don't have a good solution for. I'm bringing this up as a discussion point and is non-blocking for merge.
This doesn't matter for functionality but I'm not sure if it will be confusing or not.
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 7, 2026
…t-reader#726) ## Summary * Inverts back button behaviour while reading - short press to go home, long press to open file browser ## Additional Context * It seems counterintuitive that going into a book from home screen and pressing back doesn’t take you back to the home screen. With the recent books now displayed in the home view and a separate recents view, going directly to the file browser is less necessary.
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 8, 2026
…t-reader#726) ## Summary * Inverts back button behaviour while reading - short press to go home, long press to open file browser ## Additional Context * It seems counterintuitive that going into a book from home screen and pressing back doesn’t take you back to the home screen. With the recent books now displayed in the home view and a separate recents view, going directly to the file browser is less necessary.
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 8, 2026
…t-reader#726) ## Summary * Inverts back button behaviour while reading - short press to go home, long press to open file browser ## Additional Context * It seems counterintuitive that going into a book from home screen and pressing back doesn’t take you back to the home screen. With the recent books now displayed in the home view and a separate recents view, going directly to the file browser is less necessary.
Contributor
|
Is it live in 1.0.0-rc+9e04eec? It doesn't work like that for me. Short click still opens file manager |
Member
|
Nah sorry, it'll make it into next release |
jonasdiemer
reviewed
Feb 9, 2026
Contributor
jonasdiemer
left a comment
jonasdiemer
left a comment
There was a problem hiding this comment.
Please adjust the User Guideline.
Unintendedsideeffects
pushed a commit
to Unintendedsideeffects/crosspoint-reader
that referenced
this pull request
Feb 17, 2026
…t-reader#726) ## Summary * Inverts back button behaviour while reading - short press to go home, long press to open file browser ## Additional Context * It seems counterintuitive that going into a book from home screen and pressing back doesn’t take you back to the home screen. With the recent books now displayed in the home view and a separate recents view, going directly to the file browser is less necessary.
znelson
added a commit
that referenced
this pull request
Feb 23, 2026
## Summary * **What is the goal of this PR?** (e.g., Implements the new feature for file uploading.) - This PR updates the USER_GUIDE.md to match recent changes, in particular 1.1.0, alongside some minor copyediting. * **What changes are included?** - Renamed titles for screens to match current UI. - Sorted Settings section by order in UI, added subheadings for Settings pages, and added all current settings. - Updated System Navigation behaviour description to match #726. ## Additional Context * Add any other information that might be helpful for the reviewer (e.g., performance implications, potential risks, specific areas to focus on). This is an admittedly quick edit I did to get USER_GUIDE.md up to scratch alongside the release of 1.1.0. I'm a writer, not a programmer, so there are some things that will probably need improvement. - ~Recent Books needs to be added, something I could add to this PR if needed.~ - ~Remap Front Buttons might need to be updated.~ These have been added in later commits, Remap Front Buttons might still need more detail. - The UI Theme, Embedded Style, Hyphenation, WiFi Networks, KOReader Sync, and Clear Reading Cache settings might need better (or more technically specific) descriptions. Two questions I have: - ~Should the new Settings subheadings be added to the Table of Contents?~ Added in later commits. - The Manual of Style/formatting for USER_GUIDE.md, especially in the Settings section, is somewhat inconsistent. Let me know if any of my edits don't fit with this. --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**< YES | PARTIALLY | NO >**_ NO --------- Co-authored-by: Zach Nelson <[email protected]>
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 23, 2026
## Summary * **What is the goal of this PR?** (e.g., Implements the new feature for file uploading.) - This PR updates the USER_GUIDE.md to match recent changes, in particular 1.1.0, alongside some minor copyediting. * **What changes are included?** - Renamed titles for screens to match current UI. - Sorted Settings section by order in UI, added subheadings for Settings pages, and added all current settings. - Updated System Navigation behaviour description to match crosspoint-reader#726. ## Additional Context * Add any other information that might be helpful for the reviewer (e.g., performance implications, potential risks, specific areas to focus on). This is an admittedly quick edit I did to get USER_GUIDE.md up to scratch alongside the release of 1.1.0. I'm a writer, not a programmer, so there are some things that will probably need improvement. - ~Recent Books needs to be added, something I could add to this PR if needed.~ - ~Remap Front Buttons might need to be updated.~ These have been added in later commits, Remap Front Buttons might still need more detail. - The UI Theme, Embedded Style, Hyphenation, WiFi Networks, KOReader Sync, and Clear Reading Cache settings might need better (or more technically specific) descriptions. Two questions I have: - ~Should the new Settings subheadings be added to the Table of Contents?~ Added in later commits. - The Manual of Style/formatting for USER_GUIDE.md, especially in the Settings section, is somewhat inconsistent. Let me know if any of my edits don't fit with this. --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**< YES | PARTIALLY | NO >**_ NO --------- Co-authored-by: Zach Nelson <[email protected]>
songhyun-k
pushed a commit
to songhyun-k/crosspoint-reader-kimchi
that referenced
this pull request
Feb 24, 2026
## Summary * **What is the goal of this PR?** (e.g., Implements the new feature for file uploading.) - This PR updates the USER_GUIDE.md to match recent changes, in particular 1.1.0, alongside some minor copyediting. * **What changes are included?** - Renamed titles for screens to match current UI. - Sorted Settings section by order in UI, added subheadings for Settings pages, and added all current settings. - Updated System Navigation behaviour description to match crosspoint-reader#726. ## Additional Context * Add any other information that might be helpful for the reviewer (e.g., performance implications, potential risks, specific areas to focus on). This is an admittedly quick edit I did to get USER_GUIDE.md up to scratch alongside the release of 1.1.0. I'm a writer, not a programmer, so there are some things that will probably need improvement. - ~Recent Books needs to be added, something I could add to this PR if needed.~ - ~Remap Front Buttons might need to be updated.~ These have been added in later commits, Remap Front Buttons might still need more detail. - The UI Theme, Embedded Style, Hyphenation, WiFi Networks, KOReader Sync, and Clear Reading Cache settings might need better (or more technically specific) descriptions. Two questions I have: - ~Should the new Settings subheadings be added to the Table of Contents?~ Added in later commits. - The Manual of Style/formatting for USER_GUIDE.md, especially in the Settings section, is somewhat inconsistent. Let me know if any of my edits don't fit with this. --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**< YES | PARTIALLY | NO >**_ NO --------- Co-authored-by: Zach Nelson <[email protected]> (cherry picked from commit 75bb1d8)
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 24, 2026
## Summary * **What is the goal of this PR?** (e.g., Implements the new feature for file uploading.) - This PR updates the USER_GUIDE.md to match recent changes, in particular 1.1.0, alongside some minor copyediting. * **What changes are included?** - Renamed titles for screens to match current UI. - Sorted Settings section by order in UI, added subheadings for Settings pages, and added all current settings. - Updated System Navigation behaviour description to match crosspoint-reader#726. ## Additional Context * Add any other information that might be helpful for the reviewer (e.g., performance implications, potential risks, specific areas to focus on). This is an admittedly quick edit I did to get USER_GUIDE.md up to scratch alongside the release of 1.1.0. I'm a writer, not a programmer, so there are some things that will probably need improvement. - ~Recent Books needs to be added, something I could add to this PR if needed.~ - ~Remap Front Buttons might need to be updated.~ These have been added in later commits, Remap Front Buttons might still need more detail. - The UI Theme, Embedded Style, Hyphenation, WiFi Networks, KOReader Sync, and Clear Reading Cache settings might need better (or more technically specific) descriptions. Two questions I have: - ~Should the new Settings subheadings be added to the Table of Contents?~ Added in later commits. - The Manual of Style/formatting for USER_GUIDE.md, especially in the Settings section, is somewhat inconsistent. Let me know if any of my edits don't fit with this. --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**< YES | PARTIALLY | NO >**_ NO --------- Co-authored-by: Zach Nelson <[email protected]>
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 24, 2026
## Summary * **What is the goal of this PR?** (e.g., Implements the new feature for file uploading.) - This PR updates the USER_GUIDE.md to match recent changes, in particular 1.1.0, alongside some minor copyediting. * **What changes are included?** - Renamed titles for screens to match current UI. - Sorted Settings section by order in UI, added subheadings for Settings pages, and added all current settings. - Updated System Navigation behaviour description to match crosspoint-reader#726. ## Additional Context * Add any other information that might be helpful for the reviewer (e.g., performance implications, potential risks, specific areas to focus on). This is an admittedly quick edit I did to get USER_GUIDE.md up to scratch alongside the release of 1.1.0. I'm a writer, not a programmer, so there are some things that will probably need improvement. - ~Recent Books needs to be added, something I could add to this PR if needed.~ - ~Remap Front Buttons might need to be updated.~ These have been added in later commits, Remap Front Buttons might still need more detail. - The UI Theme, Embedded Style, Hyphenation, WiFi Networks, KOReader Sync, and Clear Reading Cache settings might need better (or more technically specific) descriptions. Two questions I have: - ~Should the new Settings subheadings be added to the Table of Contents?~ Added in later commits. - The Manual of Style/formatting for USER_GUIDE.md, especially in the Settings section, is somewhat inconsistent. Let me know if any of my edits don't fit with this. --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**< YES | PARTIALLY | NO >**_ NO --------- Co-authored-by: Zach Nelson <[email protected]>
el
pushed a commit
to el/crosspoint-reader
that referenced
this pull request
Feb 24, 2026
## Summary * **What is the goal of this PR?** (e.g., Implements the new feature for file uploading.) - This PR updates the USER_GUIDE.md to match recent changes, in particular 1.1.0, alongside some minor copyediting. * **What changes are included?** - Renamed titles for screens to match current UI. - Sorted Settings section by order in UI, added subheadings for Settings pages, and added all current settings. - Updated System Navigation behaviour description to match crosspoint-reader#726. ## Additional Context * Add any other information that might be helpful for the reviewer (e.g., performance implications, potential risks, specific areas to focus on). This is an admittedly quick edit I did to get USER_GUIDE.md up to scratch alongside the release of 1.1.0. I'm a writer, not a programmer, so there are some things that will probably need improvement. - ~Recent Books needs to be added, something I could add to this PR if needed.~ - ~Remap Front Buttons might need to be updated.~ These have been added in later commits, Remap Front Buttons might still need more detail. - The UI Theme, Embedded Style, Hyphenation, WiFi Networks, KOReader Sync, and Clear Reading Cache settings might need better (or more technically specific) descriptions. Two questions I have: - ~Should the new Settings subheadings be added to the Table of Contents?~ Added in later commits. - The Manual of Style/formatting for USER_GUIDE.md, especially in the Settings section, is somewhat inconsistent. Let me know if any of my edits don't fit with this. --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**< YES | PARTIALLY | NO >**_ NO --------- Co-authored-by: Zach Nelson <[email protected]>
el
pushed a commit
to el/crosspoint-reader
that referenced
this pull request
Feb 24, 2026
## Summary * **What is the goal of this PR?** (e.g., Implements the new feature for file uploading.) - This PR updates the USER_GUIDE.md to match recent changes, in particular 1.1.0, alongside some minor copyediting. * **What changes are included?** - Renamed titles for screens to match current UI. - Sorted Settings section by order in UI, added subheadings for Settings pages, and added all current settings. - Updated System Navigation behaviour description to match crosspoint-reader#726. ## Additional Context * Add any other information that might be helpful for the reviewer (e.g., performance implications, potential risks, specific areas to focus on). This is an admittedly quick edit I did to get USER_GUIDE.md up to scratch alongside the release of 1.1.0. I'm a writer, not a programmer, so there are some things that will probably need improvement. - ~Recent Books needs to be added, something I could add to this PR if needed.~ - ~Remap Front Buttons might need to be updated.~ These have been added in later commits, Remap Front Buttons might still need more detail. - The UI Theme, Embedded Style, Hyphenation, WiFi Networks, KOReader Sync, and Clear Reading Cache settings might need better (or more technically specific) descriptions. Two questions I have: - ~Should the new Settings subheadings be added to the Table of Contents?~ Added in later commits. - The Manual of Style/formatting for USER_GUIDE.md, especially in the Settings section, is somewhat inconsistent. Let me know if any of my edits don't fit with this. --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**< YES | PARTIALLY | NO >**_ NO --------- Co-authored-by: Zach Nelson <[email protected]>
el
pushed a commit
to el/crosspoint-reader
that referenced
this pull request
Feb 24, 2026
## Summary * **What is the goal of this PR?** (e.g., Implements the new feature for file uploading.) - This PR updates the USER_GUIDE.md to match recent changes, in particular 1.1.0, alongside some minor copyediting. * **What changes are included?** - Renamed titles for screens to match current UI. - Sorted Settings section by order in UI, added subheadings for Settings pages, and added all current settings. - Updated System Navigation behaviour description to match crosspoint-reader#726. ## Additional Context * Add any other information that might be helpful for the reviewer (e.g., performance implications, potential risks, specific areas to focus on). This is an admittedly quick edit I did to get USER_GUIDE.md up to scratch alongside the release of 1.1.0. I'm a writer, not a programmer, so there are some things that will probably need improvement. - ~Recent Books needs to be added, something I could add to this PR if needed.~ - ~Remap Front Buttons might need to be updated.~ These have been added in later commits, Remap Front Buttons might still need more detail. - The UI Theme, Embedded Style, Hyphenation, WiFi Networks, KOReader Sync, and Clear Reading Cache settings might need better (or more technically specific) descriptions. Two questions I have: - ~Should the new Settings subheadings be added to the Table of Contents?~ Added in later commits. - The Manual of Style/formatting for USER_GUIDE.md, especially in the Settings section, is somewhat inconsistent. Let me know if any of my edits don't fit with this. --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**< YES | PARTIALLY | NO >**_ NO --------- Co-authored-by: Zach Nelson <[email protected]>
el
pushed a commit
to el/crosspoint-reader
that referenced
this pull request
Feb 24, 2026
## Summary * **What is the goal of this PR?** (e.g., Implements the new feature for file uploading.) - This PR updates the USER_GUIDE.md to match recent changes, in particular 1.1.0, alongside some minor copyediting. * **What changes are included?** - Renamed titles for screens to match current UI. - Sorted Settings section by order in UI, added subheadings for Settings pages, and added all current settings. - Updated System Navigation behaviour description to match crosspoint-reader#726. ## Additional Context * Add any other information that might be helpful for the reviewer (e.g., performance implications, potential risks, specific areas to focus on). This is an admittedly quick edit I did to get USER_GUIDE.md up to scratch alongside the release of 1.1.0. I'm a writer, not a programmer, so there are some things that will probably need improvement. - ~Recent Books needs to be added, something I could add to this PR if needed.~ - ~Remap Front Buttons might need to be updated.~ These have been added in later commits, Remap Front Buttons might still need more detail. - The UI Theme, Embedded Style, Hyphenation, WiFi Networks, KOReader Sync, and Clear Reading Cache settings might need better (or more technically specific) descriptions. Two questions I have: - ~Should the new Settings subheadings be added to the Table of Contents?~ Added in later commits. - The Manual of Style/formatting for USER_GUIDE.md, especially in the Settings section, is somewhat inconsistent. Let me know if any of my edits don't fit with this. --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**< YES | PARTIALLY | NO >**_ NO --------- Co-authored-by: Zach Nelson <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Additional Context