Conversation
|
Paragraph alignments other than Justify don't seem to work. |
INSTALL
Latest ✅ -> Artifacts -> download → unzip -> firmware.bin
|
Shouldn't it be the other way around in Landscape CCW? @osteotek |
|
Is it me or menus became laggier?
|
|
I agree with @Eloren1 — waiting for the books thumbnails to load in the main menu is really annoying. |
I find that some books respect the alignment setting and others don't. I wonder if some epubs specify "Justify" in their CSS, and now that it's parsed that CSS overrides the user setting. |
But issues are issues and needs to be fixed, I don't think them will be mixed up with other issues if the version where it occurs is indicated correctly like "v1.0.0-rc" |
it's whatever you have remapped your buttons to. Changing orientation doesn't change button layout |
I think it's now respecting justify property in CSS, haven't checked that yet.
It’s how your epub’s CSS is set up to display Capital letters, need to fix. |
@Eloren1 I have encountered this too, but it seems to be because that's actually what's in the underlying epub file. (It only appears in books where the same rendering appears by design on other devices). Typically this would be a drop cap in the typeset book. Now that we're parsing CSS I guess we get the CSS that the epub suggests.
|
@osteotek I agree this is what is likely going on. This is tough because I kind of think we should overrule the book here to let the user set their book-wide alignment (small screen presents special constraints), but also want to make sure book can have things centered, or dialog aligned left and right for different speakers… |
@Eloren1 This is related to the CSS parsing feature. We use the user's paragraph alignment setting as the fallback alignment, but we use what's in the CSS as the default.
This is also likely related to the CSS and what the
Looks like another bug related to this #182. I put up a fix for closing punctuation issues related to that, but we may need a better, longer-term fix like @daveallie suggested.
The advantage is having the text represented as intended in the EPUB. One example is in the series I'm reading, Dungeon Crawler Carl, the italicized, bolded, and underlined text all have important meanings within the story itself to give extra context to the reader on what's happening within the story. But I also completely understand how the CSS parsing can disrupt the minimalism appeal of the e-reader. Since I worked on the CSS parsing feature, I'm happy to put up a PR to add in a user setting to toggle built-in CSS on/off for now. I don't think we'd be able to get as advanced with complete CSS overrides and customization that KOReader allows, but we can at least let the user turn CSS on or off. |
|
In KOReader I have embedded style off but the reader still shows bold and italic words. Best of both worlds.
This is how it works in v0.16.0 already! All we get with CSS turned ON by default is broken things that create a difference from previous reading experience. |
Thanks @jdk2pq. I think there are enough users/ebubs for which CSS may represent a degradation of the focused reading experience that having an "off" switch is highly valuable. Requested at #712 Also, there's so much inconsistency across epubs that being able to suggest as first two troubleshooting steps
|
|
@lukestein Well at this point it's better to turn the CSS off by default 😺 |
|
CSS parsing is a great addition. Some issues are expected, and we should try to fix them. |
@Eloren1 Got it, I'll look into this to see if I can support it, and I'll see if I can glean anything from the KOReader code. At the very least, I can add a global user setting to turn CSS on or off for all books. |
Thanks for this addition, @jdk2pq. The text formatting now provides an experience similar to a real book, rather than just rich text. |
While I agree, I would assume that most e-books are not produced with the screen size of the X4 in mind. Having a toggle is most likely a must, even with a complete and bug-free CSS implementation. |
@Eloren1 I do understand the frustration here, and I'm sorry this addition has broken part of the reading experience. That was definitely not the intent, and we're going to work to improve this. The CSS parsing feature parses CSS properties in the EPUB stylesheets and The feedback on this feature is definitely heard though, and I'll try to get to adding a setting for it ASAP. Thank you for the understanding. |
## Summary Increase the width of Lyra's side button hints. It has been set to 30, the same width as the classic theme. Before: <img width="457" height="742" alt="image" src="https://github.com/user-attachments/assets/316e4679-fbf0-4f6e-b117-413075da1be2" /> After: <img width="512" height="849" alt="image" src="https://github.com/user-attachments/assets/3b0cf069-55ad-4d5a-a93c-4aeca3ff67f8" /> ## Additional Context Resolves crosspoint-reader#700 (comment) --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? No
## Summary Fix for the page skip issue detected crosspoint-reader#700 (comment) by user @whyte-j Skipping down on the last page now skips to the last item, and up on the first page to the first item, rather than wrapping around the list in a weird way. ## Additional Context The calculation was outdated after several changes were added afterwards --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_
## Summary Increase the width of Lyra's side button hints. It has been set to 30, the same width as the classic theme. Before: <img width="457" height="742" alt="image" src="https://github.com/user-attachments/assets/316e4679-fbf0-4f6e-b117-413075da1be2" /> After: <img width="512" height="849" alt="image" src="https://github.com/user-attachments/assets/3b0cf069-55ad-4d5a-a93c-4aeca3ff67f8" /> ## Additional Context Resolves crosspoint-reader#700 (comment) --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? No
## Summary Fix for the page skip issue detected crosspoint-reader#700 (comment) by user @whyte-j Skipping down on the last page now skips to the last item, and up on the first page to the first item, rather than wrapping around the list in a weird way. ## Additional Context The calculation was outdated after several changes were added afterwards --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_
## Summary Fix for the page skip issue detected crosspoint-reader#700 (comment) by user @whyte-j Skipping down on the last page now skips to the last item, and up on the first page to the first item, rather than wrapping around the list in a weird way. ## Additional Context The calculation was outdated after several changes were added afterwards --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_
|
@DaniPhii yeah, looks like you're right. We can amend that to prefer consider a remote build of the same version an upgrade if you're on an RC build |
## Summary * Allow OTA update from RC build to full release * If all the segments match, then also check if the current version contains "-rc" --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? No
|
Conflicts causing the build to freeze due to using the future merge commit as the action base isn't ideal (https://github.com/orgs/community/discussions/11265). Will move the RC builds to a manual workflow. |
## Summary - Closes #730 **What is the goal of this PR?** - Adds percentage-based value support to CSS properties that accept percentages (padding, margin, text-indent) **What changes are included?** - Adds `Percent` as another CSS unit - Passes the viewport width to `fromCssStyle` so that we can resolve percentage-based values - Adds a fallback of using an emspace for text-indent if we have an unresolvable value for whatever reason ## Additional Context - This was missed in my CSS support feature, and the fallback when we encounter a percentage value is to use px instead. This means 5% (which would be ~30px on the screen) turns into 5px. When percentages are used in `text-indent`, this fallback behavior makes the indent look like a single space character. Whoops! 😬 My test EPUB has been updated [here](https://github.com/jdk2pq/css-test-epub) with percentage based CSS values at the end of the book. --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**YES**_, Claude Code
|
@daveallie No mention of Sunlight Fading Fix? It's a pretty powerful fix for a "hardware issue", but requires enabling it in the settings, so some people can miss it |
|
Good callout, will adjust the notes |
|
Hey @daveallie, regarding your update to the release notes:
In my testing I did not really see any timing differences with the sunlight fix disabled / enabled. |
Just to clarify @allgoewer , do you have AntiAliasing mode enabled or disabled? |
With anit-aliasing on, if you're in a book and press next page twice quickly the different in timing is pretty obvious. It's definitely not going to ruin days, but personally I have a black X4 for my daily driver and I'm planning to leave the setting off as the small lag is a slightly noticable for me. If the alternative was that my screen would fade in sunlight I would definitely flip the setting on. |
|
Enabled. But I do actually seem to notice a slight difference now that I'm looking closely. But im not sure if its Placebo. |
|
Updated the release notes to clarify that it's only a small difference |
## Summary Fix for the page skip issue detected crosspoint-reader#700 (comment) by user @whyte-j Skipping down on the last page now skips to the last item, and up on the first page to the first item, rather than wrapping around the list in a weird way. ## Additional Context The calculation was outdated after several changes were added afterwards --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_
Closes crosspoint-reader#712 **What is the goal of this PR?** - To add new settings for toggling on/off embedded CSS styles in the reader. This gives more control and customization to the user over how the ereader experience looks. **What changes are included?** - Added new "Embedded Style" option to the Reader settings - Added new "Book's Style" option for "Paragraph Alignment" - User's selected "Paragraph Alignment" will take precedence and override the embedded CSS `text-align` property, _unless_ the user has "Book's Style" set as their "Paragraph Alignment"  https://github.com/user-attachments/assets/9e404b13-c7e0-41c7-9406-4715f389166a Addresses feedback from the community about the new CSS feature: crosspoint-reader#700 --- While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**YES**_, Claude Code
## Summary Fix for the page skip issue detected crosspoint-reader#700 (comment) by user @whyte-j Skipping down on the last page now skips to the last item, and up on the first page to the first item, rather than wrapping around the list in a weird way. ## Additional Context The calculation was outdated after several changes were added afterwards --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_
Closes crosspoint-reader#712 ## Summary **What is the goal of this PR?** - To add new settings for toggling on/off embedded CSS styles in the reader. This gives more control and customization to the user over how the ereader experience looks. **What changes are included?** - Added new "Embedded Style" option to the Reader settings - Added new "Book's Style" option for "Paragraph Alignment" - User's selected "Paragraph Alignment" will take precedence and override the embedded CSS `text-align` property, _unless_ the user has "Book's Style" set as their "Paragraph Alignment" ## Additional Context  https://github.com/user-attachments/assets/9e404b13-c7e0-41c7-9406-4715f389166a Addresses feedback from the community about the new CSS feature: crosspoint-reader#700 --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**YES**_, Claude Code
## Summary Increase the width of Lyra's side button hints. It has been set to 30, the same width as the classic theme. Before: <img width="457" height="742" alt="image" src="https://github.com/user-attachments/assets/316e4679-fbf0-4f6e-b117-413075da1be2" /> After: <img width="512" height="849" alt="image" src="https://github.com/user-attachments/assets/3b0cf069-55ad-4d5a-a93c-4aeca3ff67f8" /> ## Additional Context Resolves crosspoint-reader#700 (comment) --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? No
## Summary Fix for the page skip issue detected crosspoint-reader#700 (comment) by user @whyte-j Skipping down on the last page now skips to the last item, and up on the first page to the first item, rather than wrapping around the list in a weird way. ## Additional Context The calculation was outdated after several changes were added afterwards --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_
Closes crosspoint-reader#712 ## Summary **What is the goal of this PR?** - To add new settings for toggling on/off embedded CSS styles in the reader. This gives more control and customization to the user over how the ereader experience looks. **What changes are included?** - Added new "Embedded Style" option to the Reader settings - Added new "Book's Style" option for "Paragraph Alignment" - User's selected "Paragraph Alignment" will take precedence and override the embedded CSS `text-align` property, _unless_ the user has "Book's Style" set as their "Paragraph Alignment" ## Additional Context  https://github.com/user-attachments/assets/9e404b13-c7e0-41c7-9406-4715f389166a Addresses feedback from the community about the new CSS feature: crosspoint-reader#700 --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**YES**_, Claude Code
## Summary Increase the width of Lyra's side button hints. It has been set to 30, the same width as the classic theme. Before: <img width="457" height="742" alt="image" src="https://github.com/user-attachments/assets/316e4679-fbf0-4f6e-b117-413075da1be2" /> After: <img width="512" height="849" alt="image" src="https://github.com/user-attachments/assets/3b0cf069-55ad-4d5a-a93c-4aeca3ff67f8" /> ## Additional Context Resolves crosspoint-reader#700 (comment) --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? No
## Summary Fix for the page skip issue detected crosspoint-reader#700 (comment) by user @whyte-j Skipping down on the last page now skips to the last item, and up on the first page to the first item, rather than wrapping around the list in a weird way. ## Additional Context The calculation was outdated after several changes were added afterwards --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_






Current RC Download
1.0.0-rc+9e04eec
CrossPoint Release Candidate
This is a CrossPoint Release Candidate. Given the speed of changes in this repo, and the volume of people using it, running a little pre-release testing is becoming necessary. This set of changes will make up the public release, any functional issues found in testing this branch over the next few days will be merged back in before the release is cut.
Is this for me?
Are you feeling a little adventurous? Do you feel comfortable running into a few last minute bugs? Then this might be for you. As mentioned below, this will only typically be relevant for a few days before these changes become generally available.
What do I need to do?
If you're willing to test out this build, just run it on your device over the next few days and report back any functional issues you find with the release. Keep in mind the feedback for this RC should not be feature requests or recommendations, they should only be bugs which would block this release from going to the public.
Where do I find the build?
The easiest way is to look at the most recent completed "Compile Release Candidate" action which should have an artifact on it containing the firmware.bin file. You can directly flash this file using https://xteink.dve.al.
When's it going to be generally available?
I'll typically leave a few days between creating a release candidate, and then cutting a public release in order to gather feedback.
What's Changed
There are a fair number of large changes in this release, including a new default UI theme, Lyra, CSS parsing within EPUBs, and full front button remapping support.
More thorough release notes will be written for the full release, as an RC tester take a scan of the items below and keep them in mind as they are the most likely areas to encounter issues.
Features
Fixes
debugging_monitor.pyscript instructions by @jdk2pq in fix: Correctdebugging_monitor.pyscript instructions #676Internal
New Contributors
debugging_monitor.pyscript instructions #676Full Changelog: 0.16.0...release/1.0.0
Issues raised for RC: