feat: A web editor for settings#667
Merged
daveallie merged 2 commits intocrosspoint-reader:masterfrom Feb 8, 2026
Merged
Conversation
daveallie
reviewed
Feb 5, 2026
Member
daveallie
left a comment
daveallie
left a comment
There was a problem hiding this comment.
Very keen for this, a bunch of settings got moved around as a part of merging the Lyra PR. Would you mind dealing with the conflicts one more time? Thanks!
obra
force-pushed
the
feature/web-settings
branch
from
94b869f to
6d52061
Compare
Contributor
Author
|
@daveallie - updated! let me know if you need anything else for this. (my guess is my dark-mode PR will need a tweak after this merges) |
Add /settings page and /api/settings GET/POST endpoints to the device web server, enabling settings management from any browser on the hotspot. - Extend SettingInfo with key, category, STRING type, and dynamic accessors for settings stored outside CrossPointSettings - Create shared SettingsList.h as single source of truth for both device UI and web API (28 settings across 6 categories) - Derive SettingsActivity categories from shared list instead of hardcoded arrays - Web-only categories: KOReader Sync (4 settings via credential store), OPDS Browser (3 string settings) - Add Settings nav link to Home and Files pages
obra
force-pushed
the
feature/web-settings
branch
from
6d52061 to
cc13162
Compare
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 8, 2026
## Summary This is an updated version of @itsthisjustin's crosspoint-reader#346 that builds on current master and also deduplicates the settings list so we don't have two copies of the settings. In the Web UI, it should organize the settings a little closer to what you see on device. ## Additional Context I tested this live on device and it seems to play nicely for me. It's re-based on master since master's settings stuff has moved somewhat since the original PR and addresses the sole review comment crosspoint-reader#346 - it also means that I don't need to manually key in the URL for my OPDS server. :) --- ### AI Usage My changes were implemented with Claude Opus 4.5 and Claude Code 2.1.25. I don't know if @itsthisjustin's original work used AI assistance. Co-authored-by: Dave Allie <[email protected]>
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 8, 2026
## Summary This is an updated version of @itsthisjustin's crosspoint-reader#346 that builds on current master and also deduplicates the settings list so we don't have two copies of the settings. In the Web UI, it should organize the settings a little closer to what you see on device. ## Additional Context I tested this live on device and it seems to play nicely for me. It's re-based on master since master's settings stuff has moved somewhat since the original PR and addresses the sole review comment crosspoint-reader#346 - it also means that I don't need to manually key in the URL for my OPDS server. :) --- ### AI Usage My changes were implemented with Claude Opus 4.5 and Claude Code 2.1.25. I don't know if @itsthisjustin's original work used AI assistance. Co-authored-by: Dave Allie <[email protected]>
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 8, 2026
## Summary This is an updated version of @itsthisjustin's crosspoint-reader#346 that builds on current master and also deduplicates the settings list so we don't have two copies of the settings. In the Web UI, it should organize the settings a little closer to what you see on device. ## Additional Context I tested this live on device and it seems to play nicely for me. It's re-based on master since master's settings stuff has moved somewhat since the original PR and addresses the sole review comment crosspoint-reader#346 - it also means that I don't need to manually key in the URL for my OPDS server. :) --- ### AI Usage My changes were implemented with Claude Opus 4.5 and Claude Code 2.1.25. I don't know if @itsthisjustin's original work used AI assistance. Co-authored-by: Dave Allie <[email protected]>
jdk2pq
added a commit
to jdk2pq/crosspoint-reader
that referenced
this pull request
Feb 9, 2026
…king-space * master: feat: Add percentage support to CSS properties (crosspoint-reader#738) Use GITHUB_REF_NAME over GITHUB_HEAD_REF in release candidate workflow Add release candidate workflow fix: Allow OTA update from RC build to full release (crosspoint-reader#778) fix(ui): Add Back label in KOReader Sync screen (crosspoint-reader#770) fix: Add EPUB 3 cover image detection (crosspoint-reader#760) feat: A web editor for settings (crosspoint-reader#667) feat: add HalStorage (crosspoint-reader#656) perf: optimize drawPixel() (crosspoint-reader#748) feat: wakeup target detection (crosspoint-reader#731) fix: Scrolling page items calculation (crosspoint-reader#716) refactor: Rename "Embedded Style" to "Book's Embedded Style" (crosspoint-reader#746) feat: optimize fillRectDither (crosspoint-reader#737)
Unintendedsideeffects
pushed a commit
to Unintendedsideeffects/crosspoint-reader
that referenced
this pull request
Feb 17, 2026
## Summary This is an updated version of @itsthisjustin's crosspoint-reader#346 that builds on current master and also deduplicates the settings list so we don't have two copies of the settings. In the Web UI, it should organize the settings a little closer to what you see on device. ## Additional Context I tested this live on device and it seems to play nicely for me. It's re-based on master since master's settings stuff has moved somewhat since the original PR and addresses the sole review comment crosspoint-reader#346 - it also means that I don't need to manually key in the URL for my OPDS server. :) --- ### AI Usage My changes were implemented with Claude Opus 4.5 and Claude Code 2.1.25. I don't know if @itsthisjustin's original work used AI assistance. Co-authored-by: Dave Allie <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is an updated version of @itsthisjustin's #346 that builds on current master and also deduplicates the settings list so we don't have two copies of the settings. In the Web UI, it should organize the settings a little closer to what you see on device.
Additional Context
I tested this live on device and it seems to play nicely for me. It's re-based on master since master's settings stuff has moved somewhat since the original PR and addresses the sole review comment #346 - it also means that I don't need to manually key in the URL for my OPDS server. :)
AI Usage
My changes were implemented with Claude Opus 4.5 and Claude Code 2.1.25. I don't know if @itsthisjustin's original work used AI assistance.