feat: add HalStorage#656
Merged
daveallie merged 10 commits intocrosspoint-reader:masterfrom Feb 8, 2026
Merged
Conversation
daveallie
reviewed
Feb 5, 2026
Member
daveallie
left a comment
daveallie
left a comment
There was a problem hiding this comment.
Keen, may need to do another sweep with the newer changes. Should we be using Storage in the lib directory instead of SdMan?
Contributor
Author
Done, rebased to latest
Yes, I just pushed a small hack to forbidden the usage of Not sure it it's the best way though, I'm open for discussion |
ngxson
force-pushed
the
xsn/hal_storage
branch
from
f147cc1 to
f0020ab
Compare
4 tasks
Contributor
Author
|
@daveallie Could you help merging this in a short time frame to avoid having more conflicts? Thanks! |
daveallie
approved these changes
Feb 8, 2026
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 8, 2026
## Summary Continue my changes to introduce the HAL infrastructure from crosspoint-reader#522 This PR touches quite a lot of files, but most of them are just name changing. It should not have any impacts to the end behavior. ## Additional Context My plan is to firstly add this small shim layer, which sounds useless at first, but then I'll implement an emulated driver which can be helpful for testing and for development. Currently, on my fork, I'm using a FS driver that allow "mounting" a local directory from my computer to the device, much like the `-v` mount option on docker. This allows me to quickly reset `.crosspoint` directory if anything goes wrong. I plan to upstream this feature when this PR get merged. --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? NO
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 8, 2026
## Summary Continue my changes to introduce the HAL infrastructure from crosspoint-reader#522 This PR touches quite a lot of files, but most of them are just name changing. It should not have any impacts to the end behavior. ## Additional Context My plan is to firstly add this small shim layer, which sounds useless at first, but then I'll implement an emulated driver which can be helpful for testing and for development. Currently, on my fork, I'm using a FS driver that allow "mounting" a local directory from my computer to the device, much like the `-v` mount option on docker. This allows me to quickly reset `.crosspoint` directory if anything goes wrong. I plan to upstream this feature when this PR get merged. --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? NO
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 8, 2026
## Summary Continue my changes to introduce the HAL infrastructure from crosspoint-reader#522 This PR touches quite a lot of files, but most of them are just name changing. It should not have any impacts to the end behavior. ## Additional Context My plan is to firstly add this small shim layer, which sounds useless at first, but then I'll implement an emulated driver which can be helpful for testing and for development. Currently, on my fork, I'm using a FS driver that allow "mounting" a local directory from my computer to the device, much like the `-v` mount option on docker. This allows me to quickly reset `.crosspoint` directory if anything goes wrong. I plan to upstream this feature when this PR get merged. --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? NO
This was referenced Feb 8, 2026
martinbrook
added a commit
to martinbrook/crosspoint-reader
that referenced
this pull request
Feb 8, 2026
Update all image-related code to use the new Storage API name introduced in PR crosspoint-reader#656.
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 9, 2026
Update all image-related code to use the new Storage API name introduced in PR crosspoint-reader#656.
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 9, 2026
Update all image-related code to use the new Storage API name introduced in PR crosspoint-reader#656.
jdk2pq
added a commit
to jdk2pq/crosspoint-reader
that referenced
this pull request
Feb 9, 2026
…king-space * master: feat: Add percentage support to CSS properties (crosspoint-reader#738) Use GITHUB_REF_NAME over GITHUB_HEAD_REF in release candidate workflow Add release candidate workflow fix: Allow OTA update from RC build to full release (crosspoint-reader#778) fix(ui): Add Back label in KOReader Sync screen (crosspoint-reader#770) fix: Add EPUB 3 cover image detection (crosspoint-reader#760) feat: A web editor for settings (crosspoint-reader#667) feat: add HalStorage (crosspoint-reader#656) perf: optimize drawPixel() (crosspoint-reader#748) feat: wakeup target detection (crosspoint-reader#731) fix: Scrolling page items calculation (crosspoint-reader#716) refactor: Rename "Embedded Style" to "Book's Embedded Style" (crosspoint-reader#746) feat: optimize fillRectDither (crosspoint-reader#737)
Marma92
pushed a commit
to Marma92/crosspoint-reader
that referenced
this pull request
Feb 10, 2026
## Summary Continue my changes to introduce the HAL infrastructure from crosspoint-reader#522 This PR touches quite a lot of files, but most of them are just name changing. It should not have any impacts to the end behavior. ## Additional Context My plan is to firstly add this small shim layer, which sounds useless at first, but then I'll implement an emulated driver which can be helpful for testing and for development. Currently, on my fork, I'm using a FS driver that allow "mounting" a local directory from my computer to the device, much like the `-v` mount option on docker. This allows me to quickly reset `.crosspoint` directory if anything goes wrong. I plan to upstream this feature when this PR get merged. --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? NO
madeddie
pushed a commit
to madeddie/crosspoint-reader
that referenced
this pull request
Feb 11, 2026
Update all image-related code to use the new Storage API name introduced in PR crosspoint-reader#656.
martinbrook
added a commit
to martinbrook/crosspoint-reader
that referenced
this pull request
Feb 13, 2026
Update all image-related code to use the new Storage API name introduced in PR crosspoint-reader#656.
Unintendedsideeffects
pushed a commit
to Unintendedsideeffects/crosspoint-reader
that referenced
this pull request
Feb 17, 2026
## Summary Continue my changes to introduce the HAL infrastructure from crosspoint-reader#522 This PR touches quite a lot of files, but most of them are just name changing. It should not have any impacts to the end behavior. ## Additional Context My plan is to firstly add this small shim layer, which sounds useless at first, but then I'll implement an emulated driver which can be helpful for testing and for development. Currently, on my fork, I'm using a FS driver that allow "mounting" a local directory from my computer to the device, much like the `-v` mount option on docker. This allows me to quickly reset `.crosspoint` directory if anything goes wrong. I plan to upstream this feature when this PR get merged. --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? NO
Unintendedsideeffects
pushed a commit
to Unintendedsideeffects/crosspoint-reader
that referenced
this pull request
Feb 17, 2026
Update all image-related code to use the new Storage API name introduced in PR crosspoint-reader#656.
Unintendedsideeffects
pushed a commit
to Unintendedsideeffects/crosspoint-reader
that referenced
this pull request
Feb 17, 2026
Update all image-related code to use the new Storage API name introduced in PR crosspoint-reader#656.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Continue my changes to introduce the HAL infrastructure from #522
This PR touches quite a lot of files, but most of them are just name changing. It should not have any impacts to the end behavior.
Additional Context
My plan is to firstly add this small shim layer, which sounds useless at first, but then I'll implement an emulated driver which can be helpful for testing and for development.
Currently, on my fork, I'm using a FS driver that allow "mounting" a local directory from my computer to the device, much like the
-vmount option on docker. This allows me to quickly reset.crosspointdirectory if anything goes wrong. I plan to upstream this feature when this PR get merged.AI Usage
While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.
Did you use AI tools to help write this code? NO