feat: button layout support - right, left, confirm, back#651
feat: button layout support - right, left, confirm, back#651aaroncunliffe wants to merge 1 commit intocrosspoint-reader:masterfrom
Conversation
aaroncunliffe
changed the title
|
Thanks @aaroncunliffe for making the change! |
|
Tested on device and seems to work as expected (although changing this setting remains confusing since toggle button jumps around with each switch) |
Looks like this is a common sentiment, this issue was also raised earlier with some good discussion ongoing - #654 |
|
@aaroncunliffe would this work for your case? #664 |
@osteotek It wasn't for my needs, this was raised in #620, I was just looking for a nice easy first issue to jump into the codebase. I'm happy to close if #664 was the direction we were wanting to go down, it would close a few open issues/PRs |
andrewb1269
left a comment
andrewb1269
left a comment
There was a problem hiding this comment.
LGTM! Thanks for putting this in! 🚀
|
Closing in favour of #664 |
5 participants
Summary
Implements new front button layouts discussed in issue: #620
resolves #620
New Layout:
Right, Left, Confirm, Back
Works best when Inverted reader mode is on.
Additional Context
Reformatted enum at SettingsActivity.cpp#L43, but made sure to run clang-format
AI Usage
While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.
Did you use AI tools to help write this code? < No >