fix: don't wake up after USB connect#644
Merged
daveallie merged 8 commits intocrosspoint-reader:masterfrom Feb 1, 2026
Merged
Conversation
daveallie
approved these changes
Feb 1, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes unintended wake-ups when USB power is connected while short power-button press mode is enabled, by distinguishing USB-power cold boots from intentional power-button wakes.
Changes:
- Replaces the boolean “wakeup by power button” check with a
WakeupReasonenum andgetWakeupReason()implementation. - In
setup(), sends the device back to deep sleep when the wake reason is “USB power” (cold boot). - Adjusts deep-sleep entry to arm GPIO wakeup after the power button is released.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/main.cpp | Uses getWakeupReason() to avoid treating USB-power cold boots as a normal wake and immediately returns to deep sleep. |
| lib/hal/HalGPIO.h | Introduces WakeupReason enum and getWakeupReason() API. |
| lib/hal/HalGPIO.cpp | Implements wake-reason classification and reorders deep-sleep wakeup arming after button release. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 1, 2026
## Summary * fixes problem that if short power button press is enabled, connecting device to usb leads to waking up
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 2, 2026
## Summary * fixes problem that if short power button press is enabled, connecting device to usb leads to waking up
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 2, 2026
## Summary * fixes problem that if short power button press is enabled, connecting device to usb leads to waking up
jdk2pq
added a commit
to jdk2pq/crosspoint-reader
that referenced
this pull request
Feb 3, 2026
* master: feat: Debugging monitor script (crosspoint-reader#555) fix: truncating chapter titles using UTF-8 safe function (crosspoint-reader#599) fix: don't wake up after USB connect (crosspoint-reader#644) Revert "fix: don't wake up after USB connect" (crosspoint-reader#643) fix: custom sleep not showing image at index 0 (crosspoint-reader#639) docs: Update USER_GUIDE.md (crosspoint-reader#625) fix: Hide button hints in landscape CW mode (crosspoint-reader#637) fix: WiFi error screen text clarifications (crosspoint-reader#612) fix: don't wake up after USB connect (crosspoint-reader#576) feat(ui): change popup logic (crosspoint-reader#442) feat: Add reading menu and delete cache function (crosspoint-reader#433)
lukestein
pushed a commit
that referenced
this pull request
Feb 3, 2026
## Summary * fixes problem that if short power button press is enabled, connecting device to usb leads to waking up
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 3, 2026
## Summary * fixes problem that if short power button press is enabled, connecting device to usb leads to waking up
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 3, 2026
## Summary * fixes problem that if short power button press is enabled, connecting device to usb leads to waking up
Unintendedsideeffects
pushed a commit
to Unintendedsideeffects/crosspoint-reader
that referenced
this pull request
Feb 17, 2026
## Summary * fixes problem that if short power button press is enabled, connecting device to usb leads to waking up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary