feat: implement user-defined apps#638
Closed
ngxson wants to merge 1 commit intocrosspoint-reader:masterfrom
Closed
feat: implement user-defined apps#638ngxson wants to merge 1 commit intocrosspoint-reader:masterfrom
ngxson wants to merge 1 commit intocrosspoint-reader:masterfrom
Conversation
Contributor
Author
|
Per discussion from #640, I'm closing this PR and moving it to my fork |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Important
This work is moved to my fork: ngxson/pluspoint-reader#2
This PR introduces the ability to load user-defined app at runtime, in form of a file saved in SD card. This opens the opportunity to add certain functionalities without having to compile it into the firmware.
Example of a simple app that updates a counter every second:
View the code
Right now, I'm still testing this implementation on my emulator, things may not work as expected in real device. I'll try to finish this PR soon, just pushing this to share and keep track of the progress.
TODO:
Design consideration
Why JS?
When starting with this idea, I had some candidates to be considered: ELF loader (native binary), Java/wasm (byte code), JS/python (interpreted)
So, I was left with the last choice is to use JS. I initially experimented with elk which works well, but not performant enough. I ended up moving to mquickjs
Why mquickjs?
Compare to other JS runtime implementation on ESP32, mquickjs is quite interesting because it supports 2 modes:
This is quite important because program code must be loaded into heap to be executed. Being able to compile code into byte code make it possible to write more complicated apps without taking too much space.
While this implementation uses ~120KB from flash usage, which is quite a lot, it does make sense because:
Limitations
Please note that I don't plan to include any networking functionalities in the initial version. They will be added the next iteration.
AI Usage
While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.
Did you use AI tools to help write this code?
Except for some comments being auto-completed by the IDE, all of the code here is written by human