Can you share some screenshots to show how it looks

Bar shows position in current chapter (or in full txt file, since they don't have chapters)

Percentage display is progress in full book/file

Centered is chapter title (or text file name)

cc: @el

I haven't checked the code in detail, but would it work if instead of adding drawChapterProgressBar() function just reuse existing one and send chapter progress number to it? Functions seems to be identical

I haven't checked the code in detail, but would it work if instead of adding drawChapterProgressBar() function just reuse existing one and send chapter progress number to it? Functions seems to be identical

Thanks @osteotek. Refactored and then tested on device with both epub and text files in both (book) progress and chapter progress settings and seems to work as expected (i.e., identical to before refactor).

I can imagine the value of the two progress bars looking different—for example, many readers offer tick marks on the book progress bar to show where the chapter breaks are—but in the absence of any plan to differentiate the two I think a single function as you suggested is def cleaner.

Looks like this would address idea #593

Looks like this would address idea #593

Thank you! I had thought there was an issue and somehow couldn't find it.

Works great on my device

However 2 small observations:

• There is documentation for this setting that seems to be missing a few options now USER_GUIDE.md
• The other options that involve progress bar are Full /w Progress Bar and Progress Bar. Full meaning it includes the battery percentage, chapter name, and book percentage - like this new option does. So does it fit better as Full /w Chapter Progress Bar?

• There is documentation for this setting that seems to be missing a few options now USER_GUIDE.md
• The other options that involve progress bar are Full /w Progress Bar and Progress Bar. Full meaning it includes the battery percentage, chapter name, and book percentage - like this new option does. So does it fit better as Full /w Chapter Progress Bar?

Thanks @aaroncunliffe!

I re-named the options (and added to the User Guide in this PR) as follows, but I'm not attached to the names:

Status Bar: Configure the status bar displayed while reading:

• "None" - No status bar
• "No Progress" - Show status bar without reading progress
• "Full w/ Percentage" - Show status bar with book progress (as percentage)
• "Full w/ Book Bar" - Show status bar with book progress (as bar)
• "Book Bar Only" - Show book progress (as bar)
• "Full w/ Chapter Bar" - Show status bar with chapter progress (as bar)

The latest changes work great on device, I'll definitely be using this as my default once it's in, nice change @lukestein.

One behaviour note: on some books it looks like the bar tracks spine item progress rather than full chapter progress. With an EPUB of The Martian, I can finish a subchapter and the bar resets while still in that same parent chapter.

I actually prefer this behaviour since the full chapter title still shows, but flagging it in case it’s unexpected.

One behaviour note: on some books it looks like the bar tracks spine item progress rather than full chapter progress. With an EPUB of The Martian, I can finish a subchapter and the bar resets while still in that same parent chapter.

I actually prefer this behaviour since the full chapter title still shows, but flagging it in case it’s unexpected.

Thanks @aaroncunliffe. I just tried to use the existing values (without really considering a spine/chapter distinction) used to calculate the chapter page display in the old, existing "full" status bar:

    if (showProgressPercentage) {
      snprintf(progressStr, sizeof(progressStr), "%d/%d  %.0f%%", section->currentPage + 1, section->pageCount,
               bookProgress);
    } else if (showBookPercentage) {
      snprintf(progressStr, sizeof(progressStr), "%.0f%%", bookProgress);
    } else {
      snprintf(progressStr, sizeof(progressStr), "%d/%d", section->currentPage + 1, section->pageCount);
    }

so I did

    const float chapterProgress =
        (section->pageCount > 0) ? (static_cast<float>(section->currentPage + 1) / section->pageCount) * 100 : 0;

I'm happy to take a suggestion (from anyone) if there's a better way to do this.

I'm not familiar enough with the underlying EPUB construction just yet to suggest a fix.

From your snippet above I've realised Full w/ Percentage which falls into the else statement also tracks this the same way, so I don't think it's too much of a problem right now. It might only be a small percentage of books structured this way.

I'd suggest leaving it as it is right now, but I am slightly biased as I prefer it this way 😄

I'm not familiar enough with the underlying EPUB construction just yet to suggest a fix.

@aaroncunliffe, I suspect we may have encountered what's behind #383 …

Testing on device (successfully) with both default and Lyra UI