feat: add burger menu for file renaming and relocation by LZando · Pull Request #619 · crosspoint-reader/crosspoint-reader

LZando · 2026-01-29T22:00:13Z

What is the goal of this PR?

Introduce a burger (overflow) menu that allows users to rename files and change their location directly from the file item actions.

UI / Frontend

Added a burger (overflow) menu to file items for quick access to actions.
Implemented modals and related logic for file and folder renaming and moving.
Relaxed filename validation rules to support spaces
(e.g., Philosophy of sd.epub).

Backend / Logic

BookCacheManager
- Introduced a new utility that automatically migrates the cache folder
  (metadata, reading progress, pre-rendered chapters) when a book’s path changes.
Recursive migration
- Moving a folder now triggers a recursive cache update for all contained books.
State persistence
- Updated RecentBooksStore to automatically refresh file paths in the Recent Books list.
- Updated CrossPointState to keep the last opened book in sync after path changes.

AI Usage

While CrossPoint does not restrict the use of AI tools for contributions, transparency is encouraged to provide proper context for reviewers.

Did you use AI tools to help write this code?
Answer: PARTIALLY

lukestein · 2026-02-02T11:41:45Z

Closes #661 and #663

lukestein · 2026-02-02T11:43:51Z

Closes #559

daveallie

Small nit, fixed up a small bug when testing. Will fix this up to get it merged into this release

daveallie · 2026-02-05T12:49:10Z

src/util/BookCacheManager.cpp

+  if (CrossPointState::getInstance().openEpubPath == oldPath.c_str()) {
+    CrossPointState::getInstance().openEpubPath = newPath.c_str();
+    CrossPointState::getInstance().saveToFile();
+  }


For consistency, we should use APP_STATE instead of CrossPointState::getInstance() here.

daveallie · 2026-02-05T12:55:21Z

After reading both implementations, going to merge #630.

If you'd like to update this to focus on the index migration, that can be done, otherwise, we can consider this solved and close it.

As per comment, merging #630

## Summary * **What is the goal of this PR?** (e.g., Implements the new feature for file uploading.) This adds renaming and moving files to the File Manager * **What changes are included?** New `/move` and `/rename` endpoints, and corresponding modals and icons added. Uses the `file.rename()` function, after sanity checking. ## Additional Context * Add any other information that might be helpful for the reviewer (e.g., performance implications, potential risks, specific areas to focus on). Fixes #559, #661, #663. Only touches the File Manager, so low risk of affecting other systems. Simpler than #619, at the cost of not migrating the cache of renamed books. <img width="870" height="437" alt="image" src="https://github.com/user-attachments/assets/73e0e750-dfc8-48e0-a7a6-9694470b7ded" /> <img width="575" height="318" alt="image" src="https://github.com/user-attachments/assets/38c5fb19-c38a-436b-b3ad-75c1be7375ab" /> <img width="574" height="293" alt="image" src="https://github.com/user-attachments/assets/1d2a2403-765d-473f-8c4f-c6968e9bbfeb" /> --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**YES**_ I used Codex for the implementation itself, and then carefully reviewed the code myself. As this is a simple change and only to the webserver, it is low risk.

Tritlo · 2026-02-05T13:01:24Z

Great @LZando should we work together on adding updated cache management on rename and move?

LZando · 2026-02-05T13:08:23Z

Great @LZando should we work together on adding updated cache management on rename and move?

I would love to work together, even though my availability for the next three weeks will be limited due to work, is it a problem?

Tritlo · 2026-02-05T13:59:01Z

no worries, just ping me when you're ready! Though I don't think I can contribute much, you are more familiar with the cache stuff.

LZando · 2026-02-05T14:06:44Z

no worries, just ping me when you're ready! Though I don't think I can contribute much, you are more familiar with the cache stuff.

I will be back with some architecture ideas

LZando · 2026-02-05T17:54:07Z

no worries, just ping me when you're ready! Though I don't think I can contribute much, you are more familiar with the cache stuff.

I’m back with two approaches.

I was thinking that the file hash cannot be based on any information that the user can change inside the file.
So the values we can rely on are:

File size
File hash

I tried to run a small script using a sparse hash, which uses the file size + the beginning and the end of the file. (in my test 4k of the head and 8kn of the tail where there is the ZIP Central Directory, which is unique to every specific compilation of a file.)

Pros of this approach:

Independence: With a sparse hash, we don’t care where the file is located or what its name is; the file’s properties are what determine the hash.

Cons of this approach:

Slower: The previous method was obviously faster because it only required hashing the path, so the SH in my test result slower 0.01ms (legacy) vs 55ms (Sparse), is possible to bring the 55ms to 20ms extracting less information but with an higher risk of collisions (10^-16 vs 10^-9, still hard it can happen).

Shouldn’t be a big deal on a enik device, but obv is important to pay attention to performance on ESP32.

The other approach is closer to the solution I proposed in my PR: using a dictionary to store the book attributes. However, this could be problematic in the future because we would always need to keep the dictionary and the book data in sync.

Probably the first one is better because easier, what do you think?

Tritlo · 2026-02-07T16:11:14Z

Good points.

For such a low powered device, I don't think we should worry about collisions. For 10^-9, you'd need ~100 million samples to even have 10% chance of a collision. Given that there have only been ~130 million books written EVER, I think that should be fine.

daveallie · 2026-02-09T09:21:41Z

Will move this one into draft while you two continue to collaborate, just so that that myself and other reviewers it's clear that this doesn't need additional review eyes.

LZando · 2026-02-11T14:37:15Z

Good points.

For such a low powered device, I don't think we should worry about collisions. For 10^-9, you'd need ~100 million samples to even have 10% chance of a collision. Given that there have only been ~130 million books written EVER, I think that should be fine.

Great! Give me two weeks and I will try to scratch the first version

## Summary * **What is the goal of this PR?** (e.g., Implements the new feature for file uploading.) This adds renaming and moving files to the File Manager * **What changes are included?** New `/move` and `/rename` endpoints, and corresponding modals and icons added. Uses the `file.rename()` function, after sanity checking. ## Additional Context * Add any other information that might be helpful for the reviewer (e.g., performance implications, potential risks, specific areas to focus on). Fixes crosspoint-reader#559, crosspoint-reader#661, crosspoint-reader#663. Only touches the File Manager, so low risk of affecting other systems. Simpler than crosspoint-reader#619, at the cost of not migrating the cache of renamed books. <img width="870" height="437" alt="image" src="https://github.com/user-attachments/assets/73e0e750-dfc8-48e0-a7a6-9694470b7ded" /> <img width="575" height="318" alt="image" src="https://github.com/user-attachments/assets/38c5fb19-c38a-436b-b3ad-75c1be7375ab" /> <img width="574" height="293" alt="image" src="https://github.com/user-attachments/assets/1d2a2403-765d-473f-8c4f-c6968e9bbfeb" /> --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**YES**_ I used Codex for the implementation itself, and then carefully reviewed the code myself. As this is a simple change and only to the webserver, it is low risk.

zandoli added 10 commits January 29, 2026 22:50

Update recent books store paths on rename/move

7753c71

Complete file rename/move handling and cache updates

b483b46

Text fix

07ccf3a

chore: trigger CI

a7dee81

chore: trigger CI

4deeeb8

chore: trigger CI

8e60334

chore: update open-x4-sdk submodule with rename support

8ec6e6b

chore: trigger CI

2a164f1

Fix open-x4-sdk submodule reference to valid commit

3ce1f1a

chore: trigger CI

8d791b6

Tritlo mentioned this pull request Jan 31, 2026

feat: rename and move in file manager #630

Merged

daveallie added 2 commits February 5, 2026 23:36

Merge branch 'master' into fork/LZando/burger-menu-clean

e8a7433

Fix rename functionality

58e4d65

daveallie requested changes Feb 5, 2026

View reviewed changes

Swap CrossPointState::getInstance() to APP_STATE

9c77147

daveallie previously approved these changes Feb 5, 2026

View reviewed changes

daveallie marked this pull request as draft February 9, 2026 09:21

Uh oh!

Conversation

LZando commented Jan 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What is the goal of this PR?

UI / Frontend

Backend / Logic

AI Usage

Uh oh!

lukestein commented Feb 2, 2026

Uh oh!

lukestein commented Feb 2, 2026

Uh oh!

daveallie left a comment

Choose a reason for hiding this comment

Uh oh!

daveallie Feb 5, 2026

Choose a reason for hiding this comment

Uh oh!

daveallie commented Feb 5, 2026

Uh oh!

Tritlo commented Feb 5, 2026

Uh oh!

LZando commented Feb 5, 2026

Uh oh!

Tritlo commented Feb 5, 2026

Uh oh!

LZando commented Feb 5, 2026

Uh oh!

LZando commented Feb 5, 2026

Uh oh!

Tritlo commented Feb 7, 2026

Uh oh!

daveallie commented Feb 9, 2026

Uh oh!

LZando commented Feb 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

LZando commented Jan 29, 2026 •

edited

Loading