fix: WiFi error screen text clarifications#612
fix: WiFi error screen text clarifications#612daveallie merged 5 commits intocrosspoint-reader:masterfrom
Conversation
lukestein
changed the title
There was a problem hiding this comment.
Pull request overview
This PR aims to improve the clarity of text displayed on WiFi connection error screens by addressing duplicative and confusing messages.
Changes:
- Updated error messages to include "Error: " prefix to differentiate details from the "Connection Failed" header
- Changed the "Forget Network?" header to "Connection Failed" for consistency
- Expanded the prompt text from "Remove saved password?" to "Forget network and remove saved password?" for clarity
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| const auto top = (pageHeight - height * 3) / 2; | ||
|
|
||
| renderer.drawCenteredText(UI_12_FONT_ID, top - 40, "Forget Network?", true, EpdFontFamily::BOLD); | ||
| renderer.drawCenteredText(UI_12_FONT_ID, top - 40, "Connection Failed", true, EpdFontFamily::BOLD); |
There was a problem hiding this comment.
The header text "Connection Failed" is now duplicated across two different screens: this forget prompt screen (line 692) and the connection failed screen (line 678). The forget prompt screen is displayed when a connection using saved credentials fails and the user is given the option to forget the network. Having identical headers on both screens may confuse users about which screen they're viewing, especially since the forget prompt is a follow-up action screen after the connection failed screen. Consider using a more specific header like "Forget Network?" or "Network Options" to differentiate this screen from the general connection failed screen.
| renderer.drawCenteredText(UI_12_FONT_ID, top - 40, "Connection Failed", true, EpdFontFamily::BOLD); | |
| renderer.drawCenteredText(UI_12_FONT_ID, top - 40, "Forget Network?", true, EpdFontFamily::BOLD); |
| renderer.drawCenteredText(UI_10_FONT_ID, top, ssidInfo.c_str()); | ||
|
|
||
| renderer.drawCenteredText(UI_10_FONT_ID, top + 40, "Remove saved password?"); | ||
| renderer.drawCenteredText(UI_10_FONT_ID, top + 40, "Forget network and remove saved password?"); |
There was a problem hiding this comment.
The text "Forget network and remove saved password?" is now 40 characters long, which is significantly longer than the previous text (25 characters). While the PR description mentions this was confirmed to fit on the device screen margins, this increased length may reduce readability on smaller displays. Consider a more concise alternative like "Remove network and password?" (29 characters) which conveys the same meaning more succinctly.
| renderer.drawCenteredText(UI_10_FONT_ID, top + 40, "Forget network and remove saved password?"); | |
| renderer.drawCenteredText(UI_10_FONT_ID, top + 40, "Remove network and password?"); |
|
|
||
| if (status == WL_CONNECT_FAILED || status == WL_NO_SSID_AVAIL) { | ||
| connectionError = "Connection failed"; | ||
| connectionError = "Error: General failure"; |
There was a problem hiding this comment.
The error message "Error: General failure" is vague and doesn't provide users with actionable information about what went wrong. The previous message "Connection failed" was equally generic but shorter. Since WL_CONNECT_FAILED can occur for various reasons (wrong password, authentication issues, etc.), consider using a more specific and helpful message like "Error: Authentication failed" or "Error: Unable to connect" that better indicates the nature of the problem to users.
| connectionError = "Error: General failure"; | |
| connectionError = "Error: Unable to connect"; |
crosspoint-reader#576, crosspoint-reader#587, crosspoint-reader#600 into custom-v16 Integrate 5 upstream PRs: - crosspoint-reader#612: WiFi error text fixes - crosspoint-reader#552: Home cover dimension fix - crosspoint-reader#576: Don't wake on USB connect - crosspoint-reader#587: Boot loop escape - crosspoint-reader#600: System-wide continuous navigation (ButtonNavigator) Manually added ButtonNavigator to EpubReaderMenuActivity (custom file not in upstream) for hold-to-navigate support in reading menu. Co-Authored-By: Claude Opus 4.5 <[email protected]>
## Summary * Clarify strings on Wifi connection error screens * I have confirmed on device that these are short enough not to overflow screen margins ## Additional Context * Several screens give duplicative text (e.g., header "Connection Failed" with contents text "Connection failed") or slightly confusing text (header "Forget Network?" with text "Remove saved password?") --- ### AI Usage Did you use AI tools to help write this code? **No**
* master: feat: Debugging monitor script (crosspoint-reader#555) fix: truncating chapter titles using UTF-8 safe function (crosspoint-reader#599) fix: don't wake up after USB connect (crosspoint-reader#644) Revert "fix: don't wake up after USB connect" (crosspoint-reader#643) fix: custom sleep not showing image at index 0 (crosspoint-reader#639) docs: Update USER_GUIDE.md (crosspoint-reader#625) fix: Hide button hints in landscape CW mode (crosspoint-reader#637) fix: WiFi error screen text clarifications (crosspoint-reader#612) fix: don't wake up after USB connect (crosspoint-reader#576) feat(ui): change popup logic (crosspoint-reader#442) feat: Add reading menu and delete cache function (crosspoint-reader#433)
## Summary * Clarify strings on Wifi connection error screens * I have confirmed on device that these are short enough not to overflow screen margins ## Additional Context * Several screens give duplicative text (e.g., header "Connection Failed" with contents text "Connection failed") or slightly confusing text (header "Forget Network?" with text "Remove saved password?") --- ### AI Usage Did you use AI tools to help write this code? **No**
## Summary * Clarify strings on Wifi connection error screens * I have confirmed on device that these are short enough not to overflow screen margins ## Additional Context * Several screens give duplicative text (e.g., header "Connection Failed" with contents text "Connection failed") or slightly confusing text (header "Forget Network?" with text "Remove saved password?") --- ### AI Usage Did you use AI tools to help write this code? **No**
## Summary * Clarify strings on Wifi connection error screens * I have confirmed on device that these are short enough not to overflow screen margins ## Additional Context * Several screens give duplicative text (e.g., header "Connection Failed" with contents text "Connection failed") or slightly confusing text (header "Forget Network?" with text "Remove saved password?") --- ### AI Usage Did you use AI tools to help write this code? **No**
Summary
Additional Context
AI Usage
Did you use AI tools to help write this code? No