feat: Add Italian hyphenation support#584
Merged
daveallie merged 12 commits intocrosspoint-reader:masterfrom Feb 9, 2026
Merged
feat: Add Italian hyphenation support#584daveallie merged 12 commits intocrosspoint-reader:masterfrom
daveallie merged 12 commits intocrosspoint-reader:masterfrom
Conversation
Member
|
Hi, thanks for the PR! Unfortunately, firmware in its current state already uses 95% of available flash size. So we've been hesitant to add new hyphenation dictionaries, which will push firmware size even higher. After we merge font improvements which will bring firmware size down significantly (hopefully soon), this and other hyphenation dictionaries will be added. |
|
Any chance this could make it into v1.0? Would be great for Italian readers! 🙏 Thank'you for your work! |
Contributor
Author
|
Build size without the PR: Build size with the PR: |
Contributor
Author
Dear Arthur, italian hyphenation is surprisingly simple and adds up only 1644 bytes to the flash size (see my previous post). Please reconsider adding it to the 1.0.0 release. |
daveallie
approved these changes
Feb 9, 2026
Member
daveallie
left a comment
daveallie
left a comment
There was a problem hiding this comment.
Hesitant to add too much more before cutting back some space, but you're right, this change is tiny and impactful.
Marma92
pushed a commit
to Marma92/crosspoint-reader
that referenced
this pull request
Feb 10, 2026
## Summary * **What is the goal of this PR?** Add Italian language hyphenation support to improve text rendering for Italian books. * **What changes are included?** * Added Italian hyphenation trie (hyph-it.trie.h) generated from Typst's hypher patterns * Registered italianHyphenator in LanguageRegistry.cpp for language tag it * Added Italian to the hyphenation evaluation test suite * Added Italian test data file with 5000 test cases ## Additional Context * Add any other information that might be helpful for the reviewer (e.g., performance implications, potential risks, specific areas to focus on). --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_ --------- Co-authored-by: drbourbon <[email protected]>
jdk2pq
added a commit
to jdk2pq/crosspoint-reader
that referenced
this pull request
Feb 11, 2026
…king-space * master: feat: use natural sort in file browser (crosspoint-reader#722) fix: issue if book href are absolute url and not relative to server (crosspoint-reader#741) feat: unify navigation handling with system-wide continuous navigation (crosspoint-reader#600) feat: Add Italian hyphenation support (crosspoint-reader#584) feat: Add percentage support to CSS properties (crosspoint-reader#738) Use GITHUB_REF_NAME over GITHUB_HEAD_REF in release candidate workflow Move release candidate workflow to manual dispatch fix: Allow OTA update from RC build to full release (crosspoint-reader#778) refactor: Rename "Embedded Style" to "Book's Embedded Style" (crosspoint-reader#746) perf: optimize drawPixel() (crosspoint-reader#748) feat: wakeup target detection (crosspoint-reader#731) fix: Scrolling page items calculation (crosspoint-reader#716) feat: optimize fillRectDither (crosspoint-reader#737) fix: increase lyra sideButtonHintsWidth to 30 (crosspoint-reader#727) fix: Remove separations after style changes (crosspoint-reader#720) fix: Lag before displaying covers on home screen (crosspoint-reader#721) feat: Add Settings for toggling CSS on or off (crosspoint-reader#717) Use GITHUB_HEAD_REF release: 1.0.0
jdk2pq
added a commit
to jdk2pq/crosspoint-reader
that referenced
this pull request
Feb 13, 2026
* master: (25 commits) fix: Reduce MIN_SIZE_FOR_POPUP to 10KB (crosspoint-reader#809) docs: Update USER_GUIDE.md (crosspoint-reader#817) fix: Prevent sleeping when in OPDS browser / downloading books (crosspoint-reader#818) feat: Extend python debugging monitor functionality (keyword filter / suppress) (crosspoint-reader#810) docs: Update USER_GUIDE.md (crosspoint-reader#808) feat: Connect to last wifi by default (crosspoint-reader#752) feat: use natural sort in file browser (crosspoint-reader#722) fix: issue if book href are absolute url and not relative to server (crosspoint-reader#741) feat: unify navigation handling with system-wide continuous navigation (crosspoint-reader#600) feat: Add Italian hyphenation support (crosspoint-reader#584) feat: Add percentage support to CSS properties (crosspoint-reader#738) Use GITHUB_REF_NAME over GITHUB_HEAD_REF in release candidate workflow Move release candidate workflow to manual dispatch fix: Allow OTA update from RC build to full release (crosspoint-reader#778) refactor: Rename "Embedded Style" to "Book's Embedded Style" (crosspoint-reader#746) perf: optimize drawPixel() (crosspoint-reader#748) feat: wakeup target detection (crosspoint-reader#731) fix: Scrolling page items calculation (crosspoint-reader#716) feat: optimize fillRectDither (crosspoint-reader#737) fix: increase lyra sideButtonHintsWidth to 30 (crosspoint-reader#727) ...
Unintendedsideeffects
pushed a commit
to Unintendedsideeffects/crosspoint-reader
that referenced
this pull request
Feb 17, 2026
## Summary * **What is the goal of this PR?** Add Italian language hyphenation support to improve text rendering for Italian books. * **What changes are included?** * Added Italian hyphenation trie (hyph-it.trie.h) generated from Typst's hypher patterns * Registered italianHyphenator in LanguageRegistry.cpp for language tag it * Added Italian to the hyphenation evaluation test suite * Added Italian test data file with 5000 test cases ## Additional Context * Add any other information that might be helpful for the reviewer (e.g., performance implications, potential risks, specific areas to focus on). --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_ --------- Co-authored-by: drbourbon <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What is the goal of this PR? Add Italian language hyphenation support to improve text rendering for Italian books.
What changes are included?
Additional Context
specific areas to focus on).
AI Usage
While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.
Did you use AI tools to help write this code? NO