fix: don't wake up after USB connect#576
Merged
daveallie merged 7 commits intocrosspoint-reader:masterfrom Feb 1, 2026
Merged
Conversation
ngxson
approved these changes
Jan 28, 2026
Comment on lines
+53
to
+54
| if ((wakeupCause == ESP_SLEEP_WAKEUP_UNDEFINED && resetReason == ESP_RST_POWERON && !usbConnected) || | ||
| (wakeupCause == ESP_SLEEP_WAKEUP_GPIO && resetReason == ESP_RST_DEEPSLEEP && usbConnected)) { |
Contributor
There was a problem hiding this comment.
I think the original if (isUsbConnected) .. else .. looks more clean. Logically say, (A & B) || (!A & C) is equivalent to if (A) then B else C
nkocher
added a commit
to nkocher/crosspoint-reader
that referenced
this pull request
Jan 31, 2026
crosspoint-reader#576, crosspoint-reader#587, crosspoint-reader#600 into custom-v16 Integrate 5 upstream PRs: - crosspoint-reader#612: WiFi error text fixes - crosspoint-reader#552: Home cover dimension fix - crosspoint-reader#576: Don't wake on USB connect - crosspoint-reader#587: Boot loop escape - crosspoint-reader#600: System-wide continuous navigation (ButtonNavigator) Manually added ButtonNavigator to EpubReaderMenuActivity (custom file not in upstream) for hold-to-navigate support in reading menu. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Member
Author
|
@daveallie I think there is a bug in this logic preventing device to wakeup, can we revert it |
Member
|
yep |
daveallie
added a commit
that referenced
this pull request
Feb 1, 2026
Reverts #576 Causing a boot loop on master
Member
Author
|
@daveallie sorry for early panic, seems like bootloop was caused by my cache containing settings from other branch. I've tested this changes again (after merging master), works as intended. Opened second PR - #644 |
Contributor
|
PR #510 might help on bad configs |
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 1, 2026
## Summary * fixes problem that if short power button press is enabled, connecting device to usb leads to waking up
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 1, 2026
Reverts crosspoint-reader#576 Causing a boot loop on master
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 2, 2026
Reverts crosspoint-reader#576 Causing a boot loop on master
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 2, 2026
Reverts crosspoint-reader#576 Causing a boot loop on master
jdk2pq
added a commit
to jdk2pq/crosspoint-reader
that referenced
this pull request
Feb 3, 2026
* master: feat: Debugging monitor script (crosspoint-reader#555) fix: truncating chapter titles using UTF-8 safe function (crosspoint-reader#599) fix: don't wake up after USB connect (crosspoint-reader#644) Revert "fix: don't wake up after USB connect" (crosspoint-reader#643) fix: custom sleep not showing image at index 0 (crosspoint-reader#639) docs: Update USER_GUIDE.md (crosspoint-reader#625) fix: Hide button hints in landscape CW mode (crosspoint-reader#637) fix: WiFi error screen text clarifications (crosspoint-reader#612) fix: don't wake up after USB connect (crosspoint-reader#576) feat(ui): change popup logic (crosspoint-reader#442) feat: Add reading menu and delete cache function (crosspoint-reader#433)
lukestein
pushed a commit
that referenced
this pull request
Feb 3, 2026
Reverts #576 Causing a boot loop on master
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 3, 2026
## Summary * fixes problem that if short power button press is enabled, connecting device to usb leads to waking up
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 3, 2026
Reverts crosspoint-reader#576 Causing a boot loop on master
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 3, 2026
## Summary * fixes problem that if short power button press is enabled, connecting device to usb leads to waking up
lukestein
pushed a commit
to lukestein/crosspoint-reader
that referenced
this pull request
Feb 3, 2026
Reverts crosspoint-reader#576 Causing a boot loop on master
Unintendedsideeffects
pushed a commit
to Unintendedsideeffects/crosspoint-reader
that referenced
this pull request
Feb 17, 2026
## Summary * fixes problem that if short power button press is enabled, connecting device to usb leads to waking up
Unintendedsideeffects
pushed a commit
to Unintendedsideeffects/crosspoint-reader
that referenced
this pull request
Feb 17, 2026
Reverts crosspoint-reader#576 Causing a boot loop on master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary