Skip to content

feat: Add Spanish hyphenation support#558

Merged
daveallie merged 1 commit intocrosspoint-reader:masterfrom
la-lo-go:feat/spanish-hyphenation
Jan 27, 2026
Merged

feat: Add Spanish hyphenation support#558
daveallie merged 1 commit intocrosspoint-reader:masterfrom
la-lo-go:feat/spanish-hyphenation

Conversation

@la-lo-go
Copy link
Contributor

@la-lo-go la-lo-go commented Jan 26, 2026

Summary

  • What is the goal of this PR? Add Spanish language hyphenation support to improve text rendering for Spanish books.
  • What changes are included?
    • Added Spanish hyphenation trie (hyph-es.trie.h) generated from Typst's hypher patterns
    • Registered spanishHyphenator in LanguageRegistry.cpp for language tag es
    • Added Spanish to the hyphenation evaluation test suite
    • Added Spanish test data file with 5000 test cases

Additional Context

  • Test Results: Spanish hyphenation achieves 99.02% F1 Score (97.72% perfect matches out of 5000 test cases)
  • Compatibility: Works automatically for EPUBs with <dc:language>es</dc:language> (or es-ES, es-MX, etc.)
imagen
Metric Value
Perfect matches 97.72%
Overall Precision 99.33%
Overall Recall 99.42%
Overall F1 Score 99.38%

AI Usage

Did you use AI tools to help write this code? PARTIALLY

AI assisted with:

  • Guiding and compile
  • Preparing the PR description

@la-lo-go la-lo-go force-pushed the feat/spanish-hyphenation branch from f9d5d78 to 52ccb39 Compare January 26, 2026 22:01
@daveallie daveallie merged commit 8e0d2be into crosspoint-reader:master Jan 27, 2026
2 checks passed
@la-lo-go la-lo-go deleted the feat/spanish-hyphenation branch January 27, 2026 14:43
jdk2pq added a commit to jdk2pq/crosspoint-reader that referenced this pull request Jan 28, 2026
* master: (33 commits)
  feat: add HalDisplay and HalGPIO (crosspoint-reader#522)
  feat: Display epub metadata on Recents (crosspoint-reader#511)
  chore: Cut release 0.16.0
  fix: Correctly render italics on image alt placeholders (crosspoint-reader#569)
  chore: .gitignore: add compile_commands.json & .cache (crosspoint-reader#568)
  fix: Render keyboard entry over multiple lines (crosspoint-reader#567)
  fix: missing front layout in mapLabels() (crosspoint-reader#564)
  refactor: Re-work for OTA feature (crosspoint-reader#509)
  perf: optimize large EPUB indexing from O(n^2) to O(n) (crosspoint-reader#458)
  feat: Add Spanish hyphenation support (crosspoint-reader#558)
  feat: Add support to B&W filters to image covers (crosspoint-reader#476)
  feat(ux): page turning on button pressed if long-press chapter skip is disabled (crosspoint-reader#451)
  feat: Add status bar option "Full w/ Progress Bar" (crosspoint-reader#438)
  fix: Validate settings on read. (crosspoint-reader#492)
  fix: rotate origin in drawImage (crosspoint-reader#557)
  feat: Extract author from XTC/XTCH files (crosspoint-reader#563)
  fix: add txt books to recent tab (crosspoint-reader#526)
  docs: add font generation commands to builtin font headers (crosspoint-reader#547)
  docs: Update README with supported languages for EPUB  (crosspoint-reader#530)
  fix: Fix KOReader document md5 calculation for binary matching progress sync (crosspoint-reader#529)
  ...
@pablohc
Copy link
Contributor

pablohc commented Jan 28, 2026

Gracias!!!

@la-lo-go
Copy link
Contributor Author

De nada 🫡

aBER0724 pushed a commit to aBER0724/crosspoint-reader-cjk that referenced this pull request Feb 1, 2026
Synced from upstream/master (da4d3b5):
- feat: Add HalDisplay and HalGPIO (crosspoint-reader#522)
- feat: Display epub metadata on Recents (crosspoint-reader#511)
- feat: Add Spanish hyphenation support (crosspoint-reader#558)
- fix: Render keyboard entry over multiple lines (crosspoint-reader#567)
- fix: missing front layout in mapLabels() (crosspoint-reader#564)
- perf: optimize large EPUB indexing from O(n^2) to O(n) (crosspoint-reader#458)
- chore: .gitignore: add compile_commands.json & .cache (crosspoint-reader#568)

Files synced:
- lib/hal/ (new)
- lib/Epub/ (hyphenation, metadata cache, parsers)
- lib/ZipFile/
- src/MappedInputManager.*
- src/activities/home/MyLibraryActivity.*
- src/activities/util/

Skipped conflicting files:
- lib/GfxRenderer/ (has CJK changes)
- src/activities/reader/ (has dark mode changes)
- src/main.cpp (has I18n changes)
Jessica765 pushed a commit to Jessica765/crosspoint-reader that referenced this pull request Feb 3, 2026
## Summary

* **What is the goal of this PR?** Add Spanish language hyphenation
support to improve text rendering for Spanish books.
* **What changes are included?**
- Added Spanish hyphenation trie (`hyph-es.trie.h`) generated from
Typst's hypher patterns
- Registered `spanishHyphenator` in `LanguageRegistry.cpp` for language
tag `es`
  - Added Spanish to the hyphenation evaluation test suite
  - Added Spanish test data file with 5000 test cases

## Additional Context

* **Test Results:** Spanish hyphenation achieves 99.02% F1 Score (97.72%
perfect matches out of 5000 test cases)
* **Compatibility:** Works automatically for EPUBs with
`<dc:language>es</dc:language>` (or es-ES, es-MX, etc.)
<img width="115" height="189" alt="imagen"
src="https://github.com/user-attachments/assets/9b92e7fc-b98d-48af-8d53-dfdc2e68abee"
/>


| Metric | Value |
|--------|-------|
| Perfect matches | 97.72% |
| Overall Precision | 99.33% |
| Overall Recall | 99.42% |
| Overall F1 Score | 99.38% |

---

### AI Usage

Did you use AI tools to help write this code? _**PARTIALLY**_

AI assisted with:
- Guiding and compile
- Preparing the PR description
Unintendedsideeffects pushed a commit to Unintendedsideeffects/crosspoint-reader that referenced this pull request Feb 17, 2026
## Summary

* **What is the goal of this PR?** Add Spanish language hyphenation
support to improve text rendering for Spanish books.
* **What changes are included?**
- Added Spanish hyphenation trie (`hyph-es.trie.h`) generated from
Typst's hypher patterns
- Registered `spanishHyphenator` in `LanguageRegistry.cpp` for language
tag `es`
  - Added Spanish to the hyphenation evaluation test suite
  - Added Spanish test data file with 5000 test cases

## Additional Context

* **Test Results:** Spanish hyphenation achieves 99.02% F1 Score (97.72%
perfect matches out of 5000 test cases)
* **Compatibility:** Works automatically for EPUBs with
`<dc:language>es</dc:language>` (or es-ES, es-MX, etc.)
<img width="115" height="189" alt="imagen"
src="https://github.com/user-attachments/assets/9b92e7fc-b98d-48af-8d53-dfdc2e68abee"
/>


| Metric | Value |
|--------|-------|
| Perfect matches | 97.72% |
| Overall Precision | 99.33% |
| Overall Recall | 99.42% |
| Overall F1 Score | 99.38% |

---

### AI Usage

Did you use AI tools to help write this code? _**PARTIALLY**_

AI assisted with:
- Guiding and compile
- Preparing the PR description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants