fix: remove decimal places from progress %#507
Merged
daveallie merged 2 commits intocrosspoint-reader:masterfrom Jan 27, 2026
Merged
fix: remove decimal places from progress %#507daveallie merged 2 commits intocrosspoint-reader:masterfrom
daveallie merged 2 commits intocrosspoint-reader:masterfrom
Conversation
treetrum
changed the title
Member
|
I'm not sure if we should create setting for every possible customization option 🙂 it is already getting bit out of hand. How about in this PR just revert to integer progress and let the maintainer(s) decide |
Contributor
|
Then we should just leave the integer |
Contributor
Author
|
Yeah, that's a fair point. Agreed that not everything needs to be a setting. My opinion is that you probably don't need decimal level precision on book progress, so happy to make this PR just revert to pre 0.15.0 behaviour. I'll update. |
treetrum
changed the title
Contributor
|
It's a fix not feat |
treetrum
changed the title
Contributor
|
Testing on device and seems to work for both epub and text files. 🎉 This issue was slightly annoying me. Thanks for fixing! |
osteotek
approved these changes
Jan 24, 2026
CaptainFrito
approved these changes
Jan 26, 2026
daveallie
approved these changes
Jan 27, 2026
Jessica765
pushed a commit
to Jessica765/crosspoint-reader
that referenced
this pull request
Feb 3, 2026
## Summary Addresses crosspoint-reader#504 - Reverts book progress % to showing as an integer instead of with a decimal place - This was changed to 1 decimal point of precision in crosspoint-reader#232 from what I can tell - As this wasn't the primary intention of that PR, I'm assuming it was left in accidentally IMO having a decimal place of precision is too much for something as vague as book completion percent. This de-clutters the status bar and prevents extra updates as you change pages. --- ### AI Usage YES
Unintendedsideeffects
pushed a commit
to Unintendedsideeffects/crosspoint-reader
that referenced
this pull request
Feb 17, 2026
## Summary Addresses crosspoint-reader#504 - Reverts book progress % to showing as an integer instead of with a decimal place - This was changed to 1 decimal point of precision in crosspoint-reader#232 from what I can tell - As this wasn't the primary intention of that PR, I'm assuming it was left in accidentally IMO having a decimal place of precision is too much for something as vague as book completion percent. This de-clutters the status bar and prevents extra updates as you change pages. --- ### AI Usage YES
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #504
IMO having a decimal place of precision is too much for something as vague as book completion percent. This de-clutters the status bar and prevents extra updates as you change pages.
AI Usage
YES