feat: Add Power Button Hold Duration setting#506
Closed
Eloren1 wants to merge 4 commits intocrosspoint-reader:masterfrom
Closed
feat: Add Power Button Hold Duration setting#506Eloren1 wants to merge 4 commits intocrosspoint-reader:masterfrom
Eloren1 wants to merge 4 commits intocrosspoint-reader:masterfrom
Conversation
nkocher
added a commit
to nkocher/crosspoint-reader
that referenced
this pull request
Jan 31, 2026
- Update current branch from theme-engine-wiggum to custom-v16 - Document v16.0 base with merged PRs crosspoint-reader#442, crosspoint-reader#506, crosspoint-reader#433 - Add git workflow for syncing with upstream - Add code style patterns (house style, null-checks, settings) - Document pre-commit hook behavior - Remove outdated theme-specific content - Update repository structure (private fork, remotes, branches) - Clean up integrated PRs table
nkocher
added a commit
to nkocher/crosspoint-reader
that referenced
this pull request
Jan 31, 2026
PR crosspoint-reader#506 added powerButtonHoldDuration but placed it in the middle of the serialization sequence. This breaks backward compatibility with existing v0.16.0 settings.bin files on SD cards. Fix: Move powerButtonHoldDuration to the end of the serialization order, after sleepScreenCoverFilter, maintaining the 'new fields at end' pattern for backward compatibility. SETTINGS_COUNT: 23 -> 24
nkocher
added a commit
to nkocher/crosspoint-reader
that referenced
this pull request
Jan 31, 2026
Critical learnings from v16.0 PR merges: - Settings serialization order must preserve backward compatibility - New settings always go at END of sequence - Document PR crosspoint-reader#506 and crosspoint-reader#433 fixes - Add working serial monitor command (cat vs pio device monitor)
Member
|
I'd prefer if we just tweaked it to a reasonable static value, I get that people want to customise their experience, but this feels like a spot where we can just make up our minds and keep the user on the rails. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Additional Context
Previous hold duration was hardcoded to 400ms, it's a bit too fast and doesn't feel like "long-press".
Now it's configurable. I still keep 0.5s as a default value, with an ability to select higher values in settings.
In fact, the difference is noticeable and therefore this is a good customization to avoid accidental clicks for some.
AI Usage
Did you use AI tools to help write this code? PARTIALLY