fix: Chapter Selection UI bugs when koreader sync is enabled, and clarify default kosync URL#501
Conversation
lukestein
changed the title
|
I've been testing on device successfully for a few days now |
|
Just testet the PR. Everything looks fine. One thought though: If the menu is split in multiple points now, is the sync option still right in the chapter menu, or should it be an own point on the top level. |
I also think the current UI (display the sync option at the top and bottom of the TOC, which may be multiple pages long…) is not ideal. Would request/suggest to @daveallie that we try to get this bug fix merged ASAP, and then let the UI decisions be integrated with all the other UI discussions going on elsewhere. |
|
Open to suggestions on placement. I figured in long books no one would want to scroll all the way up if the end was much closer |
1 similar comment
|
Open to suggestions on placement. I figured in long books no one would want to scroll all the way up if the end was much closer |
I know there are some PRs and discussion about having some kind of "reader menu" separate from the TOC, which if it happens would presumably be the right place for this to go. But given we currently only have the TOC, the problem with the current approach (imho) is that if you're at chapter 50 of a 100-chapter book you have to go multiple pages up or down to get to the sync. It feels like it should somehow be reachable on each "page" of the TOC. |
|
Agree but you can also press and hold to skip to the end |
…rify default kosync URL (crosspoint-reader#501) ## Summary * Fixes crosspoint-reader#475 * Fixes crosspoint-reader#477 * Closes crosspoint-reader#428 ## Additional Context * Updates to `src/activities/reader/EpubReaderChapterSelectionActivity.cpp` are copied verbatim from crosspoint-reader#433 (thanks to @jonasdiemer) * Update to `src/activities/settings/KOReaderSettingsActivity.cpp` per discussion with @itsthisjustin at crosspoint-reader#428 Tested on my device with several books and koreader sync turned on and off. --- ### AI Usage Did you use AI tools to help write this code? _NO_
…rify default kosync URL (crosspoint-reader#501) ## Summary * Fixes crosspoint-reader#475 * Fixes crosspoint-reader#477 * Closes crosspoint-reader#428 ## Additional Context * Updates to `src/activities/reader/EpubReaderChapterSelectionActivity.cpp` are copied verbatim from crosspoint-reader#433 (thanks to @jonasdiemer) * Update to `src/activities/settings/KOReaderSettingsActivity.cpp` per discussion with @itsthisjustin at crosspoint-reader#428 Tested on my device with several books and koreader sync turned on and off. --- ### AI Usage Did you use AI tools to help write this code? _NO_
5 participants
Summary
Additional Context
src/activities/reader/EpubReaderChapterSelectionActivity.cppare copied verbatim from feat: Add reading menu and delete cache function #433 (thanks to @jonasdiemer)src/activities/settings/KOReaderSettingsActivity.cppper discussion with @itsthisjustin at Suggestion: Include default kosync URL (sync.koreader.rocks) #428Tested on my device with several books and koreader sync turned on and off.
AI Usage
Did you use AI tools to help write this code? NO