fix: goes to relative position when reader settings are changed#486
Merged
daveallie merged 1 commit intocrosspoint-reader:masterfrom Jan 27, 2026
Conversation
Contributor
|
Testing on device and seems to work great with epubs. I've tried both rotation and font size changes. Thank you! Does not appear to do anything for text files. |
osteotek
approved these changes
Jan 24, 2026
daveallie
approved these changes
Jan 27, 2026
Jessica765
pushed a commit
to Jessica765/crosspoint-reader
that referenced
this pull request
Feb 3, 2026
…spoint-reader#486) ## Summary * **What is the goal of this PR?** (e.g., Implements the new feature for file uploading.) * Aims to fix Issue crosspoint-reader#220 * **What changes are included?** - Increased size of `progress.bin` such that total page count of current section can be stored - Comparison of total page count is done to determine if reader settings were changed - New position/page number is calculated using percentage calculated from read progress ## Additional Context * Add any other information that might be helpful for the reviewer (e.g., performance implications, potential risks, specific areas to focus on). --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_
Unintendedsideeffects
pushed a commit
to Unintendedsideeffects/crosspoint-reader
that referenced
this pull request
Feb 17, 2026
…spoint-reader#486) ## Summary * **What is the goal of this PR?** (e.g., Implements the new feature for file uploading.) * Aims to fix Issue crosspoint-reader#220 * **What changes are included?** - Increased size of `progress.bin` such that total page count of current section can be stored - Comparison of total page count is done to determine if reader settings were changed - New position/page number is calculated using percentage calculated from read progress ## Additional Context * Add any other information that might be helpful for the reviewer (e.g., performance implications, potential risks, specific areas to focus on). --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
What is the goal of this PR? (e.g., Implements the new feature for file uploading.)
Aims to fix Issue Page number should update after font size change (to maintain approximately same place in chapter, and avoid out-of-bounds) #220
What changes are included?
progress.binsuch that total page count of current section can be storedAdditional Context
specific areas to focus on).
AI Usage
While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.
Did you use AI tools to help write this code? NO