feat: add new configuration for front buttons, more usable on landscape ccw#460
Merged
daveallie merged 1 commit intocrosspoint-reader:masterfrom Jan 27, 2026
Conversation
JakeLDev
reviewed
Jan 21, 2026
src/MappedInputManager.cpp
Outdated
| switch (frontLayout) { | ||
| case CrossPointSettings::LEFT_RIGHT_BACK_CONFIRM: | ||
| return InputManager::BTN_LEFT; | ||
| return is_landscape_ccw ? InputManager::BTN_RIGHT : InputManager::BTN_LEFT; |
Contributor
There was a problem hiding this comment.
Could this be configurable in the settings instead? I use CCW too, but am now used to pressing "up" to go to the next page when holding the device with the buttons on the right. Would rather this be an option than have it be forcibly changed.
Contributor
There was a problem hiding this comment.
Agreed. I have my Kobo Libra 2 page turn buttons set to "inverted" and do not want to deal with different button orderings on each device.
Member
|
This can be done as another option for front button layout here - https://github.com/crosspoint-reader/crosspoint-reader/blob/master/src/CrossPointSettings.h#L35 |
Contributor
Author
You're right. I'll do it that way tonight. |
borisfaure
force-pushed
the
fix/invert-bottom-left-right-on-landscape-ccw
branch
from
0cc7f1b to
d03a47e
Compare
borisfaure
changed the title
JakeLDev
reviewed
Jan 22, 2026
| case CrossPointSettings::BACK_CONFIRM_RIGHT_LEFT: | ||
| return InputManager::BTN_LEFT; | ||
| case CrossPointSettings::BACK_CONFIRM_LEFT_RIGHT: | ||
| /* fall through */ |
Contributor
There was a problem hiding this comment.
Not sure all these comments add much, but otherwise looks good to me 😁👍🏻
This can feel more natural when using the Landscape CCW orientation. Update the User Guide. Also add "fall through" markers for GCC's -Wimplicit-fallthrough and to improve readability. Discussion: crosspoint-reader#449
borisfaure
force-pushed
the
fix/invert-bottom-left-right-on-landscape-ccw
branch
from
d03a47e to
0a30a16
Compare
borisfaure
changed the title
daveallie
approved these changes
Jan 27, 2026
Jessica765
pushed a commit
to Jessica765/crosspoint-reader
that referenced
this pull request
Feb 3, 2026
…pe ccw (crosspoint-reader#460) When reading on Landscape Counter ClockWise mode, the left/right button appear inverted: the upper button (left) goes down and the lower button (right) goes up. Discussion: crosspoint-reader#449 ## Summary * **What is the goal of this PR?** (e.g., Implements the new feature for file uploading.) Add a new configuration for the front buttons: Back, Confirm, Right, Left --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_
Unintendedsideeffects
pushed a commit
to Unintendedsideeffects/crosspoint-reader
that referenced
this pull request
Feb 17, 2026
…pe ccw (crosspoint-reader#460) When reading on Landscape Counter ClockWise mode, the left/right button appear inverted: the upper button (left) goes down and the lower button (right) goes up. Discussion: crosspoint-reader#449 ## Summary * **What is the goal of this PR?** (e.g., Implements the new feature for file uploading.) Add a new configuration for the front buttons: Back, Confirm, Right, Left --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**NO**_
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When reading on Landscape Counter ClockWise mode, the left/right button appear inverted: the upper button (left) goes down and the lower button (right) goes up.
Discussion: #449
Summary
Add a new configuration for the front buttons: Back, Confirm, Right, Left
AI Usage
While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.
Did you use AI tools to help write this code? NO