feat(ux): page turning on button pressed if long-press chapter skip is disabled#451
Merged
daveallie merged 6 commits intocrosspoint-reader:masterfrom Jan 27, 2026
Merged
Conversation
osteotek
changed the title
osteotek
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves the page-turning UX by making button presses more responsive when long-press chapter skip is disabled. Instead of waiting for button release, pages turn immediately on button press, providing a snappier feel.
Changes:
- Modified button input handling logic to use
wasPressed()instead ofwasReleased()when long-press chapter skip is disabled - Renamed variables from
prevReleased/nextReleasedtoprevTriggered/nextTriggeredto reflect the conditional behavior - Applied changes consistently across all three reader activity types (XTC, TXT, and EPUB)
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/activities/reader/XtcReaderActivity.cpp | Added conditional logic to trigger page turns on press vs release based on long-press setting, with skip page support |
| src/activities/reader/TxtReaderActivity.cpp | Added conditional logic to trigger page turns on press vs release based on long-press setting |
| src/activities/reader/EpubReaderActivity.cpp | Added conditional logic to trigger page turns on press vs release based on long-press setting, with chapter skip support |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
daveallie
requested changes
Jan 21, 2026
Contributor
|
Testing on device and seems to be working perfectly. Definitely makes page turns feel more snappy… to the point that I'll probably leave the long-press-for-chapter-turn setting turned off now! Seems to work great with all of
|
daveallie
previously approved these changes
Jan 27, 2026
daveallie
approved these changes
Jan 27, 2026
jdk2pq
added a commit
to jdk2pq/crosspoint-reader
that referenced
this pull request
Jan 28, 2026
* master: (33 commits) feat: add HalDisplay and HalGPIO (crosspoint-reader#522) feat: Display epub metadata on Recents (crosspoint-reader#511) chore: Cut release 0.16.0 fix: Correctly render italics on image alt placeholders (crosspoint-reader#569) chore: .gitignore: add compile_commands.json & .cache (crosspoint-reader#568) fix: Render keyboard entry over multiple lines (crosspoint-reader#567) fix: missing front layout in mapLabels() (crosspoint-reader#564) refactor: Re-work for OTA feature (crosspoint-reader#509) perf: optimize large EPUB indexing from O(n^2) to O(n) (crosspoint-reader#458) feat: Add Spanish hyphenation support (crosspoint-reader#558) feat: Add support to B&W filters to image covers (crosspoint-reader#476) feat(ux): page turning on button pressed if long-press chapter skip is disabled (crosspoint-reader#451) feat: Add status bar option "Full w/ Progress Bar" (crosspoint-reader#438) fix: Validate settings on read. (crosspoint-reader#492) fix: rotate origin in drawImage (crosspoint-reader#557) feat: Extract author from XTC/XTCH files (crosspoint-reader#563) fix: add txt books to recent tab (crosspoint-reader#526) docs: add font generation commands to builtin font headers (crosspoint-reader#547) docs: Update README with supported languages for EPUB (crosspoint-reader#530) fix: Fix KOReader document md5 calculation for binary matching progress sync (crosspoint-reader#529) ...
Jessica765
pushed a commit
to Jessica765/crosspoint-reader
that referenced
this pull request
Feb 3, 2026
…s disabled (crosspoint-reader#451) ## Summary * If long-press chapter skip is disabled, turn pages on button pressed, not released * Makes page turning snappier * Refactors MappedInputManager for readability --- ### AI Usage Did you use AI tools to help write this code? _**< PARTIALLY>**_ --------- Co-authored-by: Dave Allie <[email protected]>
Unintendedsideeffects
pushed a commit
to Unintendedsideeffects/crosspoint-reader
that referenced
this pull request
Feb 17, 2026
…s disabled (crosspoint-reader#451) ## Summary * If long-press chapter skip is disabled, turn pages on button pressed, not released * Makes page turning snappier * Refactors MappedInputManager for readability --- ### AI Usage Did you use AI tools to help write this code? _**< PARTIALLY>**_ --------- Co-authored-by: Dave Allie <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AI Usage
Did you use AI tools to help write this code? < PARTIALLY>