feat: Add reading menu and delete cache function by jonasdiemer · Pull Request #433 · crosspoint-reader/crosspoint-reader

jonasdiemer · 2026-01-19T21:50:40Z

Summary

Adds a menu in the Epub reader
The Chapter selection is moved there to pos 1 (so it can be reached by double tapping the confirm button)
A Go Home is there, too
Most significantly, a function "Delete Book Cache" is added. This returns to main (to avoid directly rebuilding cached items, eg. if this is used to debug/develop other areas - and it's also easier ;))

Probably, the Sync function could now be moved from the Chapter selection to this menu, too.

AI Usage

While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it
helps set the right context for reviewers.

Did you use AI tools to help write this code? PARTIALLY

src/activities/reader/EpubReaderActivity.cpp

lukestein · 2026-01-22T18:22:04Z

This PR fixes #475 (and presumably also fixes #477… THANK YOU!), but also does other important stuff with broader UX implications.

I hope @jonasdiemer won't mind that I've split his TOC/kosync bug fix code from here into a separate PR.

…spoint-reader#433)

@jonasdiemer

…rify default kosync URL (#501) ## Summary * Fixes #475 * Fixes #477 * Closes #428 ## Additional Context * Updates to `src/activities/reader/EpubReaderChapterSelectionActivity.cpp` are copied verbatim from #433 (thanks to @jonasdiemer) * Update to `src/activities/settings/KOReaderSettingsActivity.cpp` per discussion with @itsthisjustin at #428 Tested on my device with several books and koreader sync turned on and off. --- ### AI Usage Did you use AI tools to help write this code? _NO_

daveallie

Keen to add this submenu, just needs a bit of a cleanup

src/activities/reader/EpubReaderActivity.cpp

The chapter selection is moved to the menu on pos 1.

daveallie

Actually a couple of things after playing with it:

Let's keep the menus looking consistent for now, this PR introduces a new line height for the menu, let's make it look like the chapter select
Now that this new menu screen is the first screen you land on when pressing confirm, I think we should title it the book's title (like we currently do for the chapter select screen), and then retitle the chapter select screen to "Chapter select"

jonasdiemer · 2026-01-27T17:15:34Z

Good catch, @daveallie - unified this (incl. the position of the Chapter selection title, which was slightly off). Maybe we should have global constants for title position, menu offsets, fonts, ...

daveallie · 2026-01-27T17:36:40Z

src/activities/reader/EpubReaderActivity.cpp

@@ -419,9 +482,11 @@ void EpubReaderActivity::renderScreen() {
    data[5] = (section->pageCount >> 8) & 0xFF;


section gets reset on line 287, so this crashes

Sorry this slipped through (during rebase). Pushed a quick fix, but wondering if it would be better to re-initialize section.

- Update current branch from theme-engine-wiggum to custom-v16 - Document v16.0 base with merged PRs crosspoint-reader#442, crosspoint-reader#506, crosspoint-reader#433 - Add git workflow for syncing with upstream - Add code style patterns (house style, null-checks, settings) - Document pre-commit hook behavior - Remove outdated theme-specific content - Update repository structure (private fork, remotes, branches) - Clean up integrated PRs table

Critical learnings from v16.0 PR merges: - Settings serialization order must preserve backward compatibility - New settings always go at END of sequence - Document PR crosspoint-reader#506 and crosspoint-reader#433 fixes - Add working serial monitor command (cat vs pio device monitor)

daveallie

Looks good, I think in future we could also pass a few flags to clear cache to do things like keep / clear the progress

pablohc · 2026-02-01T11:38:13Z

Hi @jonasdiemer, in version 0.15 I was working on what I call "Magic Key." The BACK button on the HOME screen functions as a wildcard, allowing you to define these types of functions to simplify debugging tasks or any frequent function with just hold Back button. I've been working with other functions and I need to double-check that everything is working correctly in 0.16 before making a PR, but its usefulness will depend on whether there are already integrated functions in the system to be able to.

jonasdiemer · 2026-02-01T11:59:43Z

Hi @jonasdiemer, in version 0.15 I was working on what I call "Magic Key." The BACK button on the HOME screen functions as a wildcard, allowing you to define these types of functions to simplify debugging tasks or any frequent function with just hold Back button. I've been working with other functions and I need to double-check that everything is working correctly in 0.16 before making a PR, but its usefulness will depend on whether there are already integrated functions in the system to be able to.

Hi @pablohc. Not sure if this is a question... I would probably prefer explicit "debug" functions in menus rather than a magic key (if you were asking for my opinion ;) ).

## Summary * Adds a menu in the Epub reader * The Chapter selection is moved there to pos 1 (so it can be reached by double tapping the confirm button) * A Go Home is there, too * Most significantly, a function "Delete Book Cache" is added. This returns to main (to avoid directly rebuilding cached items, eg. if this is used to debug/develop other areas - and it's also easier ;)) Probably, the Sync function could now be moved from the Chapter selection to this menu, too. --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**PARTIALLY**_

* master: feat: Debugging monitor script (crosspoint-reader#555) fix: truncating chapter titles using UTF-8 safe function (crosspoint-reader#599) fix: don't wake up after USB connect (crosspoint-reader#644) Revert "fix: don't wake up after USB connect" (crosspoint-reader#643) fix: custom sleep not showing image at index 0 (crosspoint-reader#639) docs: Update USER_GUIDE.md (crosspoint-reader#625) fix: Hide button hints in landscape CW mode (crosspoint-reader#637) fix: WiFi error screen text clarifications (crosspoint-reader#612) fix: don't wake up after USB connect (crosspoint-reader#576) feat(ui): change popup logic (crosspoint-reader#442) feat: Add reading menu and delete cache function (crosspoint-reader#433)

@jonasdiemer

…rify default kosync URL (crosspoint-reader#501) ## Summary * Fixes crosspoint-reader#475 * Fixes crosspoint-reader#477 * Closes crosspoint-reader#428 ## Additional Context * Updates to `src/activities/reader/EpubReaderChapterSelectionActivity.cpp` are copied verbatim from crosspoint-reader#433 (thanks to @jonasdiemer) * Update to `src/activities/settings/KOReaderSettingsActivity.cpp` per discussion with @itsthisjustin at crosspoint-reader#428 Tested on my device with several books and koreader sync turned on and off. --- ### AI Usage Did you use AI tools to help write this code? _NO_

## Summary * Adds a menu in the Epub reader * The Chapter selection is moved there to pos 1 (so it can be reached by double tapping the confirm button) * A Go Home is there, too * Most significantly, a function "Delete Book Cache" is added. This returns to main (to avoid directly rebuilding cached items, eg. if this is used to debug/develop other areas - and it's also easier ;)) Probably, the Sync function could now be moved from the Chapter selection to this menu, too. --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**PARTIALLY**_

@jonasdiemer

…rify default kosync URL (crosspoint-reader#501) ## Summary * Fixes crosspoint-reader#475 * Fixes crosspoint-reader#477 * Closes crosspoint-reader#428 ## Additional Context * Updates to `src/activities/reader/EpubReaderChapterSelectionActivity.cpp` are copied verbatim from crosspoint-reader#433 (thanks to @jonasdiemer) * Update to `src/activities/settings/KOReaderSettingsActivity.cpp` per discussion with @itsthisjustin at crosspoint-reader#428 Tested on my device with several books and koreader sync turned on and off. --- ### AI Usage Did you use AI tools to help write this code? _NO_

## Summary * Adds a menu in the Epub reader * The Chapter selection is moved there to pos 1 (so it can be reached by double tapping the confirm button) * A Go Home is there, too * Most significantly, a function "Delete Book Cache" is added. This returns to main (to avoid directly rebuilding cached items, eg. if this is used to debug/develop other areas - and it's also easier ;)) Probably, the Sync function could now be moved from the Chapter selection to this menu, too. --- ### AI Usage While CrossPoint doesn't have restrictions on AI tools in contributing, please be transparent about their usage as it helps set the right context for reviewers. Did you use AI tools to help write this code? _**PARTIALLY**_

lgarbarini reviewed Jan 20, 2026

View reviewed changes

src/activities/reader/EpubReaderActivity.cpp Outdated Show resolved Hide resolved

jonasdiemer changed the title ~~feat:Add reading menu and delete cache function~~ feat: Add reading menu and delete cache function Jan 20, 2026

jonasdiemer mentioned this pull request Jan 22, 2026

Bug: ">> Sync Progress" label broken in TOC when kosync turned on #475

Closed

osteotek mentioned this pull request Jan 22, 2026

Feature/In-Reader Rotation Shortcut #493

Closed

lukestein added a commit to lukestein/crosspoint-reader that referenced this pull request Jan 22, 2026

Fix chapter selection bugs when koreader sync enabled (code from cros…

733fa1e

…spoint-reader#433)

lukestein mentioned this pull request Jan 22, 2026

fix: Chapter Selection UI bugs when koreader sync is enabled, and clarify default kosync URL #501

Merged

lukestein added a commit to lukestein/crosspoint-reader that referenced this pull request Jan 23, 2026

Fix chapter selection bugs when koreader sync enabled (code from cros…

631668f

…spoint-reader#433)

lukestein added a commit to lukestein/crosspoint-reader that referenced this pull request Jan 24, 2026

Fix chapter selection bugs when koreader sync enabled (code from cros…

c03e372

…spoint-reader#433)

lukestein added a commit to lukestein/crosspoint-reader that referenced this pull request Jan 26, 2026

Fix chapter selection bugs when koreader sync enabled (code from cros…

3b004d7

…spoint-reader#433)

daveallie requested changes Jan 27, 2026

View reviewed changes

src/activities/reader/EpubReaderActivity.cpp Outdated Show resolved Hide resolved

daveallie mentioned this pull request Jan 27, 2026

feat: Add settings menu to epub reader #417

Closed

jonasdiemer added 3 commits January 27, 2026 14:49

Adding Ebook menu, go home, clear cache options.

85a9204

The chapter selection is moved to the menu on pos 1.

Refactor saving progress to dedicated function.

de17b5d

Formatting fixes

f20cb10

jonasdiemer force-pushed the feature/delete-cache branch from 7fe6dda to f20cb10 Compare January 27, 2026 14:46

jonasdiemer added 2 commits January 27, 2026 15:48

Fixed merge f'up.

6e24b50

Moved callbacks into private functions.

1cbe081

jonasdiemer mentioned this pull request Jan 27, 2026

Feature Request: Add refresh screen on power button short press #550

Open

daveallie approved these changes Jan 27, 2026

View reviewed changes

daveallie requested changes Jan 27, 2026

View reviewed changes

jonasdiemer added 2 commits January 27, 2026 18:12

Unified styling (matching settings screen).

c51eb6a

Unified action.

3312b72

daveallie requested changes Jan 27, 2026

View reviewed changes

Fix crash due to use of reset section.

90d459f

daveallie approved these changes Feb 1, 2026

View reviewed changes

daveallie merged commit f935b59 into crosspoint-reader:master Feb 1, 2026
1 check passed

daveallie mentioned this pull request Feb 5, 2026

chore(release): 1.0.0 Release Candidate #700

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: Add reading menu and delete cache function#433

feat: Add reading menu and delete cache function#433
daveallie merged 8 commits intocrosspoint-reader:masterfrom
jonasdiemer:feature/delete-cache

jonasdiemer commented Jan 19, 2026

Uh oh!

Uh oh!

lukestein commented Jan 22, 2026 •

edited

Loading

Uh oh!

daveallie left a comment

Uh oh!

Uh oh!

daveallie left a comment

Uh oh!

jonasdiemer commented Jan 27, 2026

Uh oh!

daveallie Jan 27, 2026

Uh oh!

jonasdiemer Jan 27, 2026

Uh oh!

daveallie left a comment

Uh oh!

Uh oh!

pablohc commented Feb 1, 2026

Uh oh!

jonasdiemer commented Feb 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		@@ -419,9 +482,11 @@ void EpubReaderActivity::renderScreen() {
		data[5] = (section->pageCount >> 8) & 0xFF;

Uh oh!

Conversation

jonasdiemer commented Jan 19, 2026

Summary

AI Usage

Uh oh!

Uh oh!

lukestein commented Jan 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daveallie left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

daveallie left a comment

Choose a reason for hiding this comment

Uh oh!

jonasdiemer commented Jan 27, 2026

Uh oh!

daveallie Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

jonasdiemer Jan 27, 2026

Choose a reason for hiding this comment

Uh oh!

daveallie left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pablohc commented Feb 1, 2026

Uh oh!

jonasdiemer commented Feb 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

lukestein commented Jan 22, 2026 •

edited

Loading