Refactors Calibre Wireless Device & Calibre Library#404
Refactors Calibre Wireless Device & Calibre Library#404daveallie merged 16 commits intocrosspoint-reader:masterfrom
Conversation
now supports viewing books on device and deleting them
|
@daveallie until this is merged calibre device transfers will be broken sadly. It's insanely inconsistent apparently due to the chipsets wifi implementation. Works great 3 times in a row, fails 6 times in a row after that. I spent 3 days trying to fix until I gave up and just added official crosspoint device support to calibre itself. Let me know if you want the calibre plugin in it's own repo that I can maintain without muddying up prs here or if you want it to stay within this repo. The cool side effect of this is you can now manage your device wirelessly with calibre including deleting files and eventually syncing progress |
itsthisjustin
changed the title
|
Hey @itsthisjustin, very glad you found a way around this, flakey bugs are actually the devil. As you offered I'd prefer to split out the Calibre plugin into its own repo in the organisation, I've invited you to the organisation, and I've created a new repo to house this (and potentially future plugins we may need): https://github.com/crosspoint-reader/calibre-plugins. I'll grant you write access to that repo once you're in the organisation. |
|
Hi @itsthisjustin I apologize for bothering, but I’m wondering if it’s possible to complete this PR. It seems like there aren’t many tasks left to complete, but I might be mistaken. I’m more than willing to assist with it. |
|
Functionally it should be good if you want to fix anything up be my guest |
|
@itsthisjustin I've made PR to to your branch that resolves conflicts with master (and removing calibre plugin - to be uploaded to https://github.com/crosspoint-reader/calibre-plugins) Calibre plugin is exactly what I wanted, btw, thanks |
chore: merge upstream master
|
@daveallie would it be possible to merge this one, I've tested it, works well |
|
Looks good, I've moved that plugin code over to https://github.com/crosspoint-reader/calibre-plugins, and updated the docs here. |
…r#404) Our esp32 consistently dropped the last few packets of the TCP transfer in the old implementation. Only about 1/5 transfers would complete. I've refactored that entire system into an actual Calibre Device Plugin that basically uses the exact same system as the web server's file transfer protocol. I kept them separate so that we don't muddy up the existing file transfer stuff even if it's basically the same at the end of the day I didn't want to limit our ability to change it later. I've also added basic auth to OPDS and renamed that feature to OPDS Browser to just disassociate it from Calibre. --------- Co-authored-by: Arthur Tazhitdinov <[email protected]> Co-authored-by: Dave Allie <[email protected]>
…r#404) Our esp32 consistently dropped the last few packets of the TCP transfer in the old implementation. Only about 1/5 transfers would complete. I've refactored that entire system into an actual Calibre Device Plugin that basically uses the exact same system as the web server's file transfer protocol. I kept them separate so that we don't muddy up the existing file transfer stuff even if it's basically the same at the end of the day I didn't want to limit our ability to change it later. I've also added basic auth to OPDS and renamed that feature to OPDS Browser to just disassociate it from Calibre. --------- Co-authored-by: Arthur Tazhitdinov <[email protected]> Co-authored-by: Dave Allie <[email protected]>
High: - X3-3: fetchComic() now updates currentComic = num immediately at the top of the function (when num > 0) so navigation always advances past a failed comic; previously currentComic was only updated on JSON parse success, causing comic crosspoint-reader#404 (and any other missing comic) to retry forever when the user pressed Right Low: - X3-1: png.open() failure path in downloadAndDisplayImage() now clears the screen and shows the standard failure message instead of leaving the stale "Decoding..." text on screen; subsequent render() calls from scroll will also show the correct failure state rather than "Image loading..." which falsely implied the image might still arrive Co-Authored-By: Claude Sonnet 4.6 (1M context) <[email protected]>
3 participants
Our esp32 consistently dropped the last few packets of the TCP transfer in the old implementation. Only about 1/5 transfers would complete. I've refactored that entire system into an actual Calibre Device Plugin that basically uses the exact same system as the web server's file transfer protocol. I kept them separate so that we don't muddy up the existing file transfer stuff even if it's basically the same at the end of the day I didn't want to limit our ability to change it later.
I've also added basic auth to OPDS and renamed that feature to OPDS Browser to just disassociate it from Calibre.